628598 - Failed test-widget.testConstructor

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Matěj Cepl]

Attachment: complete cfx testall -v log

Using FF4b9 (Mozilla/5.0 (X11; Linux x86_64; rv:2.0b9) Gecko/20110121 Firefox/4.0b9) with Add-on SDK out of git (commit 0f9e14ea9d9f3251cbe925e2b69facd31376be8a) I get this failed test:

info: executing 'test-widget.testConstructor'
info: pass: panel has correct number of child elements after widget construction
error: TEST FAILED: test-widget.testConstructor (failure)
error: fail: content iframe has correct default height (26 != 16)
info: Traceback (most recent call last):
  File "resource://testpkgs-api-utils-lib/timer.js", line 64, in notifyOnTimeout
    this._callback.apply(null, this._params);
  File "resource://testpkgs-api-utils-lib/unit-test.js", line 223, in null
    timer.setTimeout(function() { onDone(self); }, 0);
  File "resource://testpkgs-api-utils-lib/unit-test.js", line 248, in runNextTes
t
    self.start({test: test, onDone: runNextTest});
  File "resource://testpkgs-api-utils-lib/unit-test.js", line 266, in start
    this.test.testFunction(this);
  File "resource://testpkgs-api-utils-lib/unit-test-finder.js", line 57, in runT
est
    test(runner);
  File "resource://testpkgs-addon-kit-tests/test-widget.js", line 26, in null
    test.assertEqual(widgetNode(0).firstChild.boxObject.height, 16, "content ifr
ame has correct default height");
  File "resource://testpkgs-api-utils-lib/unit-test.js", line 195, in assertEqua
l
    this.fail(message);
  File "resource://testpkgs-api-utils-lib/unit-test.js", line 113, in fail
    console.trace();

Complete log of cfx testall -v (with another failed test as described in bug 614079) is attached.

Comment 1

[Brian Warner [:warner :bwarner]]

I see a similar failure in the same test case on OS-X and FFb9 and current
jetpack trunk:

error: TEST FAILED: test-widget.testConstructor (failure)
error: fail: content iframe has correct default height (21 != 16)
info: Traceback (most recent call last):
  File "resource://testpkgs-api-utils-lib/timer.js", line 64, in notifyOnTimeout
    this._callback.apply(null, this._params);
  File "resource://testpkgs-api-utils-lib/unit-test.js", line 223, in null
    timer.setTimeout(function() { onDone(self); }, 0);
  File "resource://testpkgs-api-utils-lib/unit-test.js", line 248, in runNextTest
    self.start({test: test, onDone: runNextTest});
  File "resource://testpkgs-api-utils-lib/unit-test.js", line 266, in start
    this.test.testFunction(this);
  File "resource://testpkgs-api-utils-lib/unit-test-finder.js", line 57, in runTest
    test(runner);
  File "resource://testpkgs-addon-kit-tests/test-widget.js", line 26, in null
    test.assertEqual(widgetNode(0).firstChild.boxObject.height, 16, "content iframe has correct default height");
  File "resource://testpkgs-api-utils-lib/unit-test.js", line 195, in assertEqual
    this.fail(message);
  File "resource://testpkgs-api-utils-lib/unit-test.js", line 113, in fail
    console.trace();

I don't see it against current (2011-01-25) Minefield, though.

Comment 2

[Matěj Cepl]

I do see it with Mozilla/5.0 (X11; Linux x86_64; rv:2.0b10) Gecko/20110125 Firefox/4.0b10 and 0f9e14ea.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

This looks like a regression from the fix for bug 626728.

This is not in the 1.0b2rc1 build, which I built before that change landed.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Fixed by reverting the change that broke the test.

https://github.com/mozilla/addon-sdk/commit/044023ee9f174bdf35e36426e8855f662006c31d

Comment 5

[Dietrich Ayala (:dietrich)]

Argh, sorry, I forgot to check the tree state when I checked in :(

This test passed on Linux, but I apparently it's not multi-platform-safe.