628633 - [Regression] Find in Page does not scroll down when hitting the Down Arrow from the findbar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Anna (Waverley)]

Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b10pre) Gecko/20110125
Firefox/4.0b10pre Fennec /4.0b4pre

Steps to reproduce:

1. Go to “about:” system page
2. Bring up the “Find In Page” toolbar by tapping on the page favicon and then
“Find in page”.
3. Enter string “mozilla” in the search field.

Expected result:
As you enter the string, character by character, the page scrolls along to the
location of found text which is highlighted.

Actual result:
No panning occurs. The first string "mozilla" is highlighted, but tapping the
down arrow does not pan the page to the second string "mozilla". One has to
dismiss the VKB to see the highlighted string.

Comment 1

[Tony Chung [:tchung]]

Anna, can you track down a regression range?

Comment 2

[Anna (Waverley)]

The Virtual Keyboard and Find Toolbar did not covered the written area from about: on build ID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b8pre) Gecko/20101117 Firefox/4.0b8pre Fennec /4.0b3pre and the previous builds of this one.  Please the attached photo 1.

So basically, I would say that the first build with problems was: 
BUILD ID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b8pre) Gecko/20101118 Firefox/4.0b8pre Fennec /4.0b3pre. ---> When popping up the VKB + findbar, the second "mozilla" term was half covered and the page did not pan to the second "mozilla".  Please see the attached photo 2.
Built from: http://hg.mozilla.org/mozilla-central/rev/7e42ccaa7269

The problem described in the bug first appeared with the build: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b8pre) Gecko/20101123 Firefox/4.0b8pre Fennec /4.0b3pre. The second term "mozilla" was entirely covered by the VKB + findbar. This was introduced in the same time when the autosuggestion bar feature was implemented. The exact behavior : Please see photo 3. (The findabar is separated from the autosuggestion bar). 
Built from: http://hg.mozilla.org/mozilla-central/rev/4b9ba5049e66

Comment 3

[Anna (Waverley)]

Attachment: photo1

Comment 4

[Anna (Waverley)]

Attachment: photo2

Comment 5

[Anna (Waverley)]

Attachment: photo3

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 509400 [details] [diff] [review]
Patch


>   _zoom: function _findHelperZoom(aElementRect) {
>     // Zoom to a specified Rect
>-    if (aElementRect && Browser.selectedTab.allowZoom && Services.prefs.getBoolPref("findhelper.autozoom")) {
>+    let autozoomEnabled = Services.prefs.getBoolPref("formhelper.autozoom");

Can we add a check here for aElementRect and autozoomEnabled? That way we can remove them both if statements below:

      if (!aElementRect || !autozoomEnabled)
        return;

Then the "else if" below becomes an "else"

>+    if (aElementRect && Browser.selectedTab.allowZoom && autozoomEnabled) {

>+    } else if (aElementRect && !Browser.selectedTab.allowZoom && autozoomEnabled) {

>     }

r+ with the simplification

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/ca6ea793ee18

Comment 9

[Anna (Waverley)]

Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b12pre) Gecko/20110204 Firefox/4.0b12pre Fennec /4.0b5pre 

Device: Motorola Droid 2 (Android 2.2)

The behavior described in this bug is not reproducing anymore. But as you can notice from the following video: http://www.youtube.com/user/qaioana#p/u/0/Yh9ENzEkadw it takes a few seconds to find the first "mozilla" term. 

Is there a solution to fix this issue? I'll wait for your answer in order to validate the bug.

Comment 10

[Anna (Waverley)]

VERIFIED FIXED on
Mozilla /5.0 (Android;Linux armv7l;rv:2.0b12pre) Gecko/20110208
Firefox/4.0b12pre Fennec /4.0b5pre 

Device: Motorola Droid 2 (Android 2.2)