Closed Bug 628827 Opened 10 years ago Closed 10 years ago

Blinky double-tap zoom and pinch to zoom

Categories

(Firefox for Android Graveyard :: Panning/Zooming, defect)

defect
Not set
normal

Tracking

(fennec2.0b4+)

VERIFIED FIXED
Tracking Status
fennec 2.0b4+ ---

People

(Reporter: stechz, Assigned: stechz)

References

Details

(Keywords: regression)

Attachments

(1 file)

No description provided.
Comment on attachment 506933 [details] [diff] [review]
Blinky double-tap zoom and pinch to zoom

I remember now. The animated zoom and setVisibleRect code *used* to use the underlying frameloader stuff for a reason. We don't want the displayport flashing like crazy while we set the appropriate scale and scroll to the right area.

We can have a real API for this in 628799.
Attachment #506933 - Flags: review?(mbrubeck)
Assignee: nobody → ben
Status: NEW → ASSIGNED
Blocks: 605618
tracking-fennec: --- → ?
Keywords: regression
Comment on attachment 506933 [details] [diff] [review]
Blinky double-tap zoom and pinch to zoom

>+++ b/chrome/content/browser.js

>+    view.setScale(scale);
>+    view._contentView.scrollTo(scrollX, scrollY);
>+
>+    browser.scale = scale;

Ouch, this is ugly.  Let's get a real API in bug 628799 ASAP.
Attachment #506933 - Flags: review?(mbrubeck) → review+
tracking-fennec: ? → 2.0b4+
Pushed http://hg.mozilla.org/mobile-browser/rev/5e23feb286de
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Can this be marked as verified fixed?
Verified fixed on trunk.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.