628827 - Blinky double-tap zoom and pinch to zoom

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Comment 1

[Benjamin Stover (:stechz)]

Attachment: Blinky double-tap zoom and pinch to zoom

Comment 2

[Benjamin Stover (:stechz)]

Comment on attachment 506933 [details] [diff] [review]
Blinky double-tap zoom and pinch to zoom

I remember now. The animated zoom and setVisibleRect code *used* to use the underlying frameloader stuff for a reason. We don't want the displayport flashing like crazy while we set the appropriate scale and scroll to the right area.

We can have a real API for this in 628799.

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 506933 [details] [diff] [review]
Blinky double-tap zoom and pinch to zoom

>+++ b/chrome/content/browser.js

>+    view.setScale(scale);
>+    view._contentView.scrollTo(scrollX, scrollY);
>+
>+    browser.scale = scale;

Ouch, this is ugly.  Let's get a real API in bug 628799 ASAP.

Comment 4

[Benjamin Stover (:stechz)]

Pushed http://hg.mozilla.org/mobile-browser/rev/5e23feb286de

Comment 5

[Andreea Pod]

Can this be marked as verified fixed?

Comment 6

[Matt Brubeck (:mbrubeck)]

Verified fixed on trunk.