628871 - Warning about missing <em:type> element is listed under Security tests

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P4)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Notice the warnings under Security tests @ https://addons.allizom.org/en-US/developers/upload/d99e309e870044bbb2fd78a64e9697ab

why is the warning "No <em:type> element found in install.rdf" listed under Security tests? It should be under General tests.

Comment 1

[Matt Basta [:basta]]

Fixed:

https://github.com/mattbasta/amo-validator/commit/8ac5d91f28fb6005b51f6a6352aedc4600ee8edf

pop_state() was being called after the tier was reverted back. This should be fixed; unit tests are bundled with the updates from chaos chimp.

Comment 2

[Kumar McMillan [:kumar]]

What commit has updates from chaos chimp?  Please try to commit tests that complement a bug fix in the same patch as the bug fix.  git add -p can help with that.

This fix has been pushed to Zamboni in https://github.com/jbalogh/zamboni-lib/commit/71df61d

Comment 3

[krupa raj[:krupa]]

Attachment: screenshot

<em:type> is still listed under Security tests. See https://addons.allizom.org/en-US/developers/upload/ac00b12040dc474b9b06f6de33e51dc3

Am I missing something?

Comment 4

[Matt Basta [:basta]]

Kumar: They're being pushed to the 'chaos' branch of the validator. There's a few loose ends, so I'm hesitant to merge to master quite yet.

Anyway, looks like bits and pieces got separated. I just moved everything over to master so it should be good to go. Totally my bad:

https://github.com/mattbasta/amo-validator/commit/6caff54ad4a74ad3a3ae96e7482747fe54b0094b

Comment 5

[Kumar McMillan [:kumar]]

I pushed master to zamboni in https://github.com/jbalogh/zamboni-lib/commit/2f404be

Comment 6

[krupa raj[:krupa]]

verified @ https://addons.allizom.org/en-US/developers/upload/0f9a20573fda45c48d0958aa899f13fd