All users were logged out of Bugzilla on October 13th, 2018

Warning about missing <em:type> element is listed under Security tests

VERIFIED FIXED in 5.12.8

Status

P4
normal
VERIFIED FIXED
8 years ago
3 years ago

People

(Reporter: krupa.mozbugs, Assigned: basta)

Tracking

Details

(Whiteboard: [validator], URL)

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
steps to reproduce:
1. Notice the warnings under Security tests @ https://addons.allizom.org/en-US/developers/upload/d99e309e870044bbb2fd78a64e9697ab

why is the warning "No <em:type> element found in install.rdf" listed under Security tests? It should be under General tests.
Priority: -- → P4
(Assignee)

Comment 1

8 years ago
Fixed:

https://github.com/mattbasta/amo-validator/commit/8ac5d91f28fb6005b51f6a6352aedc4600ee8edf

pop_state() was being called after the tier was reverted back. This should be fixed; unit tests are bundled with the updates from chaos chimp.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
What commit has updates from chaos chimp?  Please try to commit tests that complement a bug fix in the same patch as the bug fix.  git add -p can help with that.

This fix has been pushed to Zamboni in https://github.com/jbalogh/zamboni-lib/commit/71df61d
(Reporter)

Comment 3

8 years ago
Created attachment 508468 [details]
screenshot

<em:type> is still listed under Security tests. See https://addons.allizom.org/en-US/developers/upload/ac00b12040dc474b9b06f6de33e51dc3

Am I missing something?
(Reporter)

Updated

8 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

8 years ago
Kumar: They're being pushed to the 'chaos' branch of the validator. There's a few loose ends, so I'm hesitant to merge to master quite yet.

Anyway, looks like bits and pieces got separated. I just moved everything over to master so it should be good to go. Totally my bad:

https://github.com/mattbasta/amo-validator/commit/6caff54ad4a74ad3a3ae96e7482747fe54b0094b
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.