628879 - Restartless add-ons missing flags

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Description

[Justin Scott [:fligtar]]

https://addons.allizom.org/en-US/firefox/addon/restartless-restart/
https://addons.mozilla.org/en-US/firefox/addon/mozilla-labs-prospector-instan/
https://addons.mozilla.org/en-US/firefox/addon/mozilla-labs-lab-kit/

I don't know why they aren't showing up in add-ons mxr, but some of the most popular restartless add-ons aren't flagged.

Comment 1

[Jeff Balogh (:jbalogh)]

In happier news, files uploaded to zamboni are getting marked as no_restart even when they're not jetpacks (like https://addons.mozilla.org/en-US/firefox/addon/bug622507/).

Comment 2

[Justin Scott [:fligtar]]

What did you fix for this bug?

Comment 3

[Jeff Balogh (:jbalogh)]

(In reply to comment #2)
> What did you fix for this bug?

All of the add-ons you listed are now marked as restartless.

Comment 4

[Justin Scott [:fligtar]]

(In reply to comment #3)
> (In reply to comment #2)
> > What did you fix for this bug?
> 
> All of the add-ons you listed are now marked as restartless.

Yes, but did we find out what the cause was or did you just do the 3 I listed? I know of more than the 3 I listed.

Comment 5

[Jeff Balogh (:jbalogh)]

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > What did you fix for this bug?
> > 
> > All of the add-ons you listed are now marked as restartless.
> 
> Yes, but did we find out what the cause was or did you just do the 3 I listed?
> I know of more than the 3 I listed.

No, I don't know about mxr and don't think it's worth diving into. I think fixing these manually is the most efficient way to go since it will eventually become consistent as new versions get uploaded to zamboni.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Reopening; https://addons.allizom.org/en-US/firefox/addon/restartless-restart/ is back to *missing* the "No restart required" message on its details page.

Comment 7

[Jeff Balogh (:jbalogh)]

The change was only made in prod: https://addons.mozilla.org/en-US/firefox/addon/restartless-restart/

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Typo in the first line of comment 0, then!.  Verified.