Intermittent layout/base/tests/test_after_paint_pref.html | Test timed out

RESOLVED FIXED in mozilla6

Status

()

defect
RESOLVED FIXED
9 years ago
7 years ago

People

(Reporter: philor, Assigned: roc)

Tracking

({intermittent-failure})

Trunk
mozilla6
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1296010912.1296013084.16701.gz
Rev3 WINNT 6.1 tracemonkey debug test mochitests-4/5 on 2011/01/25 19:01:52
s: talos-r3-w7-044

176 INFO TEST-PASS | /tests/layout/base/tests/test_after_paint_pref.html | pref defaults to true in mochitest harness - true should equal true
(...GC...)
177 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_after_paint_pref.html | Test timed out.
178 INFO TEST-END | /tests/layout/base/tests/test_after_paint_pref.html | finished in 311313ms
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1296048329.1296053618.21520.gz
OS X 10.6 comm-central-trunk debug test mochitests-4/5 on 2011/01/26 05:25:29
{
175 INFO TEST-START | /tests/layout/base/tests/test_after_paint_pref.html
...
176 INFO TEST-PASS | /tests/layout/base/tests/test_after_paint_pref.html | pref defaults to true in mochitest harness - true should equal true
...
177 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_after_paint_pref.html | Test timed out.
178 INFO TEST-END | /tests/layout/base/tests/test_after_paint_pref.html | finished in 328987ms
}
OS: Windows 7 → All
Hardware: x86 → All
Background-color is still red, so I suspect MozAfterPaint was fired before "load" event.
(In reply to comment #74)
> Created attachment 525600 [details]
> screenshoot from the log in comment #37
> 
> Background-color is still red, so I suspect MozAfterPaint was fired before
> "load" event.

That seems to be the case, yes.  Roc, this can happen, right?  Should we make sure that we ignore any MozAfterPaint events fired before the load event?
(In reply to comment #130)
> That seems to be the case, yes.  Roc, this can happen, right?  Should we
> make sure that we ignore any MozAfterPaint events fired before the load
> event?

It already does, right?
(In reply to comment #132)
> (In reply to comment #130)
> > That seems to be the case, yes.  Roc, this can happen, right?  Should we
> > make sure that we ignore any MozAfterPaint events fired before the load
> > event?
> 
> It already does, right?

Well, not really.  I mean, the test is trying to wait for a MozAfterPaint event after the load event.  But if that event is fired before the load event, this test will fail, right?
(In reply to comment #136)
> Well, not really.  I mean, the test is trying to wait for a MozAfterPaint
> event after the load event.  But if that event is fired before the load
> event, this test will fail, right?

Ah, so we want to *not* ignore MozAfterPaints before the load event, or else trigger painting during the load event to ensure that a MozAfterPaint does fire after load.
Posted patch fix? (obsolete) — Splinter Review
Assignee: nobody → roc
Attachment #533124 - Flags: review?(ehsan)
Posted patch fix v2Splinter Review
The previous version had a bug, using undefined "event". This one passes.
Attachment #533124 - Attachment is obsolete: true
Attachment #533233 - Flags: review?(ehsan)
Attachment #533124 - Flags: review?(ehsan)
Comment on attachment 533233 [details] [diff] [review]
fix v2

Yes, I think this should fix the problem.
Attachment #533233 - Flags: review?(ehsan) → review+
Whiteboard: [orange] → [orange][needs landing]
http://hg.mozilla.org/projects/cedar/rev/3cb82b65c736
Whiteboard: [orange][needs landing] → [orange][fixed-in-cedar]
http://hg.mozilla.org/mozilla-central/rev/3cb82b65c736
Whiteboard: [orange][fixed-in-cedar] → [orange]
Target Milestone: --- → mozilla6
Let's call this fixed. If it happens again on mozilla-central, we should reopen.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.