628922 - layout should use cached nsIAccessibilityService

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

That allows us to create accessible tree and make layout notifications to a11y faster.

Comment 1

[alexander :surkov (:asurkov)]

try server build - http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/[e-mail]-ebf6f70656b7

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 507057 [details] [diff] [review]
patch

r=me, the logic looks right to me. Maybe not a concern, but MOZ_ENABLE_LIBXUL is not true for Thunderbird right?

>+#ifdef MOZ_ENABLE_LIBXUL
>+    return GetAccService();
>+#else
>+    if (gIsAccessibilityActive) {
>+      nsCOMPtr<nsIAccessibilityService> srv =
>+        do_GetService("@mozilla.org/accessibilityService;1");
>+      return srv;
>+    }
>+    return nsnull;
>+#endif

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+#ifdef ACCESSIBILITY
+#include "nsServiceManagerUtils.h"
+#include "nsAccessibilityService.h"
+#endif
+

Can we not do this, and just make AccService() non-inline?

Comment 4

[alexander :surkov (:asurkov)]

Attachment: patch2

fix Robert's comment, use nsAccessibilityService directly

Comment 5

[alexander :surkov (:asurkov)]

landed on 2.0 beta11 - http://hg.mozilla.org/mozilla-central/rev/cb3fcbce2ef4

Comment 6

[Ginn Chen]

return static_cast<nsAccessibilityService*>(srv);

This line failed with Solaris Studio.

return static_cast<nsAccessibilityService*>(srv.get());

will work.

Comment 7

[alexander :surkov (:asurkov)]

Attachment: solaris fix

Comment 8

[alexander :surkov (:asurkov)]

(In reply to comment #6)
> return static_cast<nsAccessibilityService*>(srv);
> 
> This line failed with Solaris Studio.
> 
> return static_cast<nsAccessibilityService*>(srv.get());
> 
> will work.

Thanks, Ginn! Does non libxul build is used on Solaris?

Comment 9

[Ginn Chen]

Not for release build. Sometimes I use non libxul debug build to save recompiling time.

Comment 10

[alexander :surkov (:asurkov)]

(In reply to comment #7)
> Created attachment 507783 [details] [diff] [review]
> solaris fix

landed on 2.0 - http://hg.mozilla.org/mozilla-central/rev/42ff81cddcec

Comment 11

[(no longer active)]

Comment on attachment 507783 [details] [diff] [review]
solaris fix

FWIW, this is not a Solaris specific fix, this is a C++ language fix!  :-)

Comment 12

[alexander :surkov (:asurkov)]

(In reply to comment #11)
> Comment on attachment 507783 [details] [diff] [review]
> solaris fix
> 
> FWIW, this is not a Solaris specific fix, this is a C++ language fix!  :-)

I got it but after some time :) Just Ginn reports Solaris specific bugs from time to time and I thought nsCOMPtr should have overridden casting (perhaps it has but it's used for implicit casting only).