Closed Bug 629122 Opened 9 years ago Closed 9 years ago

Crashed tab causes displayport to stop setting

Categories

(Firefox for Android Graveyard :: Panning/Zooming, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stechz, Assigned: stechz)

Details

Attachments

(1 file, 1 obsolete file)

This is because browser.active is no longer true.
Attachment #507196 - Flags: review?(wjohnston)
Comment on attachment 507196 [details] [diff] [review]
Crashed tab causes displayport to stop setting

Added mfinkle for feedback. I think it's bad that we have selecting a tab code in more than one place, because then we can update one without updating the other (exactly what happened here). If you agree, we can file a bug.
Attachment #507196 - Flags: feedback?(mark.finkle)
Assignee: nobody → ben
Status: NEW → ASSIGNED
Comment on attachment 507196 [details] [diff] [review]
Crashed tab causes displayport to stop setting

I think you are right about selectedTab. Why not call

Browser.selectedTab = Browser.selectedTab

Then we can adjust the setter, and kill off the rest of the stuff in that restore section?
Comment on attachment 507196 [details] [diff] [review]
Crashed tab causes displayport to stop setting

Can we just make this part of the resurrection process?

http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser.js#2611

let active = this.active;

// kill and re-create
http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser.js#2615

if (active)
  this.active = true;

(only fire the active property if this tab was really active. no sense firing the de-activation code)
Attachment #507196 - Attachment is obsolete: true
Attachment #507196 - Flags: review?(wjohnston)
Attachment #507196 - Flags: feedback?(mark.finkle)
Attachment #508592 - Flags: review?(wjohnston)
Attachment #508592 - Flags: review?(wjohnston) → review+
Landed http://hg.mozilla.org/mobile-browser/rev/994fa1d84081
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Can somebody verify this bug?
You need to log in before you can comment on or make changes to this bug.