629160 - Generating CASE_EXIT for some default cases in tableswitch when tracing

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Hannes Verschore [:h4writer]]

User-Agent:       Mozilla/5.0 (X11; Linux i686; rv:2.0b10pre) Gecko/20110125 Firefox/4.0b10pre
Build Identifier: 

For some inputs to a switch we are taking the CASE_EXIT guard instead of using the DEFAULT_EXIT. Therefor they don't get matched and every time a new trace will get recorded. 

In the code the default exit gets taken when:
current_case - lowest_case >= count_cases

Now this isn't an issue when we are tracing integers,
but isn't true when the input is a double.

Then the default exit should get taken when:
current_case - lowest_case >= count_cases || jsint(current_case) != current_case

Reproducible: Always

Comment 1

[Hannes Verschore [:h4writer]]

Attachment: Patch

Here is the patch that solves the issue.

Comment 2

[Nicholas Nethercote [inactive]]

Bug 620757 removed this code, thus rendering this bug moot!