629213 - Add ADU API Call

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

This bug is designed to split up the work in Bug 571696.  See the attached patch in that bug to implement that API call.

Implement the ADU API call as described in:
http://code.google.com/p/socorro/wiki/AduDetailsAPI

Comment 1

[Laura Thomson :laura]

Attachment: patch ported to 1.7.x

I ported ozten's patch from 571696 to trunk.

Comment 2

[Laura Thomson :laura]

Sending        scripts/config/webapiconfig.py.dist
Adding         socorro/services/aduByDayDetails.py
Transmitting file data ..
Committed revision 2948.

Comment 3

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Laura - Please make sure the api config change is documented in the 1.7.7 upgrade notes.

https://code.google.com/p/socorro/wiki/SocorroUpgrade#Socorro_1.7.7

Comment 4

[Laura Thomson :laura]

(In reply to comment #3)
> Laura - Please make sure the api config change is documented in the 1.7.7
> upgrade notes.
> 
> https://code.google.com/p/socorro/wiki/SocorroUpgrade#Socorro_1.7.7

Done.

Comment 5

[Matt Brandt [:mbrandt]]

For QA what is the best route to test this or is this [qa-]?

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Rob, mind helping Matt/me coming up with a/few test(s) this, so we can also plan on getting it into our Selenium suite?  Thanks!

Comment 7

[Matt Brandt [:mbrandt]]

nudge nudge ... see comment 6

Comment 8

[Robert Helmer [:rhelmer]]

(In reply to comment #6)
> Rob, mind helping Matt/me coming up with a/few test(s) this, so we can also
> plan on getting it into our Selenium suite?  Thanks!

Sure, I am not familiar with this code so I've been looking through it.

This is how the API call happens internally:
https://socorro-api.stage.mozilla.com/bpapi/201005/adu/byday/p/Firefox/v/3.6.7/rt/crash/os/Windows/start/2010-08-01/end/2010-08-08

I think the UI addition that this is for, is this graph:

https://crash-stats.stage.mozilla.com/daily?form_selection=by_report_type&p=Firefox&v[]=4.0b13pre&throttle[]=100.00&v[]=&throttle[]=10.00&v[]=&throttle[]=10.00&v[]=&throttle[]=10.00&report_type[]=crash&report_type[]=oopp&report_type[]=hang_browser&report_type[]=hang_plugin&os[]=Windows&os[]=Mac&os[]=Linux&date_start=2011-04-04&date_end=2011-04-18&submit=Generate

Details are in bug https://bugzilla.mozilla.org/show_bug.cgi?id=571696

Hopefully rysny will let us know if I am steering you wrong here.

Comment 9

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

That's right Rob, the Crashes per ADU by Type query on the ADU page utilizes the new API call.

Comment 10

[Matt Brandt [:mbrandt]]

Verified by following the url in comment 8.