Closed
Bug 629233
Opened 13 years ago
Closed 13 years ago
Intermittent "TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug608037.js | Test timed out" during OSX 10.6 opt Moth
Categories
(Firefox Graveyard :: Panorama, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cjones, Assigned: ttaubert)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 2 obsolete files)
5.26 KB,
patch
|
Details | Diff | Splinter Review |
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1296082252.1296083652.15832.gz Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central opt test mochitest-other on 2011/01/26 14:50:52 s: talos-r3-snow-048 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug608037.js | Test timed out TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug608037.js | Found a tab after previous test timed out: http://mochi.test:8888/browser/browser/base/content/test/tabview/dummy_page.html TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug608037.js | Found a tab after previous test timed out: http://mochi.test:8888/ TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug608158.js | Test timed out TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug624265.js | Test timed out TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug624265.js | Found a tab after previous test timed out: http://mochi.test:8888/ TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug624265.js | Found a tab after previous test timed out: http://mochi.test:8888/
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•13 years ago
|
||
Removed duplicate functions that are now provided in head.js. Made the test more robust. Pushed to try.
Attachment #507547 -
Flags: review?(ian)
Comment 2•13 years ago
|
||
Comment on attachment 507547 [details] [diff] [review] patch v1 Looks good, except: >+function whenTabIsReconnected(tab, callback) { >+ let tabItem = tab._tabViewTabItem; >+ >+ if (tabItem._reconnected) { >+ callback(); >+ return; >+ } >+ >+ tabItem.addSubscriber(tabTwo, "reconnected", function () { >+ tabItem.removeSubscriber(tabTwo, "reconnected"); >+ callback(); >+ }); >+} ... shouldn't be using tabTwo here... tabItem should be fine. R+ with that fixed. A=test
Attachment #507547 -
Flags: review?(ian) → review+
Assignee | ||
Comment 3•13 years ago
|
||
(In reply to comment #2) > ... shouldn't be using tabTwo here... tabItem should be fine. R+ with that > fixed. A=test Oops :)
Attachment #507547 -
Attachment is obsolete: true
Assignee | ||
Comment 4•13 years ago
|
||
Forgot to add r=/a= info.
Attachment #507968 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 5•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/cb0f7b37208d
Updated•13 years ago
|
Whiteboard: [qa-]
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•