629233 - Intermittent "TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug608037.js | Test timed out" during OSX 10.6 opt Moth

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1296082252.1296083652.15832.gz
Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central opt test mochitest-other on 2011/01/26 14:50:52 

s: talos-r3-snow-048
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug608037.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug608037.js | Found a tab after previous test timed out: http://mochi.test:8888/browser/browser/base/content/test/tabview/dummy_page.html
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug608037.js | Found a tab after previous test timed out: http://mochi.test:8888/
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug608158.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug624265.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug624265.js | Found a tab after previous test timed out: http://mochi.test:8888/
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug624265.js | Found a tab after previous test timed out: http://mochi.test:8888/

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Removed duplicate functions that are now provided in head.js. Made the test more robust. Pushed to try.

Comment 2

[Ian Gilman [:iangilman]]

Comment on attachment 507547 [details] [diff] [review]
patch v1

Looks good, except: 

>+function whenTabIsReconnected(tab, callback) {
>+  let tabItem = tab._tabViewTabItem;
>+
>+  if (tabItem._reconnected) {
>+    callback();
>+    return;
>+  }
>+
>+  tabItem.addSubscriber(tabTwo, "reconnected", function () {
>+    tabItem.removeSubscriber(tabTwo, "reconnected");
>+    callback();
>+  });
>+}

... shouldn't be using tabTwo here... tabItem should be fine. R+ with that fixed. A=test

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch for checkin

(In reply to comment #2)
> ... shouldn't be using tabTwo here... tabItem should be fine. R+ with that
> fixed. A=test

Oops :)

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch for checkin

Forgot to add r=/a= info.

Comment 5

[Jacek Caban]

http://hg.mozilla.org/mozilla-central/rev/cb0f7b37208d