629271 - jetpack-sdk test on XP throws "uncaught exception: TypeError: "use strict";tab is undefined"

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Just started running this on XP against the jetpack repo in new location. It consistently fails on XP with the following error:

.....
4270 of 4273 tests passed.
FAIL
er/content/browser.xul" line: 0}]
.console: [JavaScript Error: "uncaught exception: TypeError: "use strict";tab is undefined"]
console: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/browser.xul" line: 0}]
.console: [JavaScript Error: "uncaught exception: TypeError: "use strict";tab is undefined"]
console: [JavaScript Error: "gNavigatorBundle is not defined" {file: "chrome://browser/content/browser.js" line: 3393}]
console: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/browser.xul" line: 0}]
.console: [JavaScript Error: "uncaught exception: TypeError: "use strict";tab is undefined"]
console: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/browser.xul" line: 0}]
.console: [JavaScript Error: "uncaught exception: TypeError: "use strict";tab is undefined"]
............................................................................................................................................console: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/browser.xul" line: 0}]
........................................console: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/browser.xul" line: 0}]
.......console: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/browser.xul" line: 0}]
......console: [JavaScript Error: "[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/browser.js :: FullZoom_destroy :: line 187"  data: no]" {file: "chrome://browser/content/browser.js" line: 6873}]
console: [JavaScript Error: "uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/browser.js :: BrowserShutdown :: line 6876"  data: no]"]
console: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/browser.xul" line: 0}]
......console: [JavaScript Error: "uncaught exception: TypeError: "use strict";tab is undefined"]
console: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/browser.xul" line: 0}]
console: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/browser.xul" line: 0}]
.....
4270 of 4273 tests passed.
FAIL
Total time: 165.234000 seconds
Program terminated unsuccessfully.
Some tests were unsuccessful.

If it helps, full log can be found here: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1296090222.1296090632.21108.gz

Comment 1

[Brian Warner [:warner :bwarner]]

One of the test failures occurs before that point (and happens twice, for
some weird reason):

== packages/api-utils/tests/test-file.js testBasename (line 48)

info: Traceback (most recent call last):
  File "resource://testpkgs-api-utils-lib/timer.js", line 64, in notifyOnTimeout
    this._callback.apply(null, this._params);
  File "resource://testpkgs-api-utils-lib/unit-test.js", line 223, in null
    timer.setTimeout(function() { onDone(self); }, 0);
  File "resource://testpkgs-api-utils-lib/unit-test.js", line 248, in runNextTest
    self.start({test: test, onDone: runNextTest});
  File "resource://testpkgs-api-utils-lib/unit-test.js", line 266, in start
    this.test.testFunction(this);
  File "resource://testpkgs-api-utils-lib/unit-test-finder.js", line 57, in runTest
    test(runner);
  File "resource://testpkgs-api-utils-tests/test-file.js", line 48, in null
    "basename should work on paths with no components");
  File "resource://testpkgs-api-utils-lib/unit-test.js", line 195, in assertEqual
    this.fail(message);
  File "resource://testpkgs-api-utils-lib/unit-test.js", line 113, in fail
    console.trace();

==

Wow, there's a lot of noise in there. I think we've seen the
nsIObserverService.removeObserver errors before and they don't seem to cause
actual failures (I suspect it's a race between shutdown and deregistration).
The '"use strict";tab is undefined' lines are related to bug 628112, and
might go away after the patch for it lands. I haven't seen the "XUL box for
_moz_generated_content_after" warnings before.

We should probably change the way those tests are run by the buildbot, so
that they emit one-line-per-test instead of one-dot-per-test: that would make
the source of the warning messages a lot easier to track down, and might make
the overall output a lot more legible. I'll look into how to make the jetpack
test harness operate that way.

Comment 2

[Drew Willcoxon :adw]

I filed bug 629813 for the error in comment 1.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

I think this is now fixed.  Please reopen if that is not actually the case!