629307 - No warning before closing multiple tabs even with browser.warnOnQuit set to true

Status: VERIFIED INVALID

(Firefox :: Session Restore, defect)

Description

[Emanuel Hoogeveen [:ehoogeveen]]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b11pre) Gecko/20110126 Firefox/4.0b11pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b11pre) Gecko/20110126 Firefox/4.0b11pre

This preference was set to false by default in the behavior change introduced by bug 592822. As I am not comfortable with my session always being saved without warning, I have tried changing the preference back, but the pref change has had no effect. On my laptop running Windows Vista x64, using the same nightly, the pref works as expected - could this be a problem with my profile?

Reproducible: Always

Steps to Reproduce:
1. Set browser.warnOnQuit to true in about:config
2. Start a session with multiple tabs
3. Close the browser
Actual Results:  
Get the warnOnQuit dialog box asking you what to do.

Expected Results:  
Browser closes and automatically saves my session.

Bug 550559 sounds somewhat related, but that doesn't explain why the pref works as expected on my laptop. I'd rather not trash this profile if at all possible.

Comment 1

[Emanuel Hoogeveen [:ehoogeveen]]

I should add that using a new profile (with the -profile and -no-remote switches) does indeed result in the expected behavior.

Comment 2

[Marco Bonardo [:mak]]

maybe you have some add-on conflicting with it? did you try Help / Restart With add-ons disabled?

Comment 3

[Emanuel Hoogeveen [:ehoogeveen]]

Just tried it - no change. Please let me know if there's anything else I can try or data I can collect to diagnose this.

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

In your "broken" profile, do you have Firefox set to restore your windows & tabs from last time? If so you won't get a prompt even with warnOnQuit == true. That relationship didn't change in bug 592822 - Firefox 3, 3.5, and 3.6 were like that.

Comment 5

[Emanuel Hoogeveen [:ehoogeveen]]

It does do this (restore tabs from last time) but I don't know where this option is set. about:support doesn't list anything to do with session restore in the 'Modified Preferences' section, but that section doesn't mention the fact that I have browser.warnOnQuit set to true either, even though this is not the default!

Comment 6

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #5)
> It does do this (restore tabs from last time) but I don't know where this
> option is set.

That's actually a visible preference. The very first thing in the options dialog in the general pane.

Closing this since this is expected behavior based on the preference combo.

Comment 7

[Emanuel Hoogeveen [:ehoogeveen]]

Well, this is embarrassing. I swear I had set this to show my home page. I must have changed it by accident while fiddling with the new behavior before. Incidentally, it seems odd to me that this preference doesn't have an about:config counterpart (or if it does it's not showing up in about:support as a modified preference). Either way, setting this to show my home page does fix the 'problem'.

Comment 8

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Don't worry about it. Bugs get filed & closed all the time. Glad we could clear it up though.

It does have an about:config counterpart (most everything in the preference dialog does). In this case browser.startup.page where 3 = restore session. But it interestingly doesn't show up in about:support... Not sure how that's determined.