629339 - custom toolbars should be positioned immediately below bookmarks toolbar

Status: NEW

(Firefox :: Toolbars and Customization, defect)

Description

[Valerio]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; it; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; it; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13

adding a new toolbar from the window "Customize Toolbar", this remains detached from the the other toolbars


Reproducible: Always

Comment 1

[Valerio]

Attachment: Toolbar detached

image of the problem

Comment 2

[Valerio]

Attachment: Correct position for toolbars

with this code the toolbars are in the right position:

/*MENUBAR TOOLBAR*/
#navigator-toolbox[tabsontop="false"] #toolbar-menubar
 { -moz-box-ordinal-group: 1 !important; }

/*NAVIGATION TOOLBAR(urlbar and searchbar)*/
#navigator-toolbox[tabsontop="false"] #nav-bar 
{ -moz-box-ordinal-group: 2 !important; }

/*BOOKMARKS TOOLBAR*/
#navigator-toolbox[tabsontop="false"] #PersonalToolbar
 { -moz-box-ordinal-group: 3 !important; }

/*EXTRA TOOLBARS ADDED*/
#navigator-toolbox[tabsontop="false"] [ID^='__customToolbar']
{ -moz-box-ordinal-group: 4 !important; }

Comment 3

[pino_sb]

The last lines of comment 2 does not function. The code does work, since the default ordinal-group number for custom toolbars is 10, and the others are simply moved up. For not breaking things, the following probably is better (obviously based on Valerio's, just changed a bit by me).

#navigator-toolbox[tabsontop="false"] > [id^="__customToolbar"] { 
  -moz-box-ordinal-group: 75 !important; 
  }

It places custom toolbars between bookmarks (=50) and tabbar (=100). 
For a reason I can't understand, this code, unlike the one in comment 2, changes behavior in tabs on top mode. In tabs on top, only the first custom toolbar will now be placed above bookmarks toolbar, all others beneath it. Since the code explicitly should not affect tabsontop, I just don't get it.

Comment 4

[Valerio]

Hi pino, have you restarted the browser after the change? I've tried your change and I had the same problem but after a restart it worked

Comment 5

[Frank Yan (:fryn)]

Alex, where did we want the custom toolbars to go in tabs-on-top and tabs-on-bottom mode? And should they be detached or attached? With glassed or opaque background?

Comment 6

[Frank Yan (:fryn)]

Nevermind. I found it:

Tabs on top:
https://wiki.mozilla.org/images/a/aa/Firefox-4-Mockup-i06-%28Win7%29-%28Aero%29-%28TabsTop%29-%28ExtraToolbars%29.png

Tabs on bottom:
https://wiki.mozilla.org/images/1/11/Firefox-4-Mockup-i06-%28Win7%29-%28Aero%29-%28TabsBottom%29-%28ExtraToolbars%29.png

Comment 7

[Frank Yan (:fryn)]

Since this is not really a problem in the default tabs-on-top configuration, this is a low priority bug, so unassigning myself.