Closed Bug 629418 Opened 13 years ago Closed 13 years ago

If the add-ons manager is opened as a background tab (e.g. by session restore) then the back and forward buttons are hidden

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla2.0b11

People

(Reporter: mossop, Assigned: mossop)

Details

Attachments

(1 file)

patch rev 1
3.20 KB, patch
Unfocused
: review+
sdwilsh
: approval2.0+
Details | Diff | Splinter Review 
Because the add-ons manager on startup tests whether the global back/forward buttons are visible if it is opened in the background then they will be and so it hides its own.
OS: Mac OS X → All
Hardware: x86 → All
Assignee: nobody → dtownsend
Attached patch patch rev 1 — — Splinter Review 
Pretty straightforward, check the state whenever the window gets focused (which happens whenever the selected tab changes)
Attachment #508581 - Flags: review?(bmcbride)
Attachment #508581 - Flags: review?(bmcbride) → review+
Comment on attachment 508581 [details] [diff] [review]
patch rev 1

Should be basically no risk here, all we are doing is checking whether to show the buttons more often than now in the worst case. Fixes an annoying usability issue
Attachment #508581 - Flags: approval2.0?
Attachment #508581 - Flags: approval2.0? → approval2.0+
Landed: http://hg.mozilla.org/mozilla-central/rev/4b8f9705b339
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b10
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b11) Gecko/20100101 Firefox/4.0b11. Updating TM because that was really fixed for b11 and not b10.
Status: RESOLVED → VERIFIED
Target Milestone: mozilla2.0b10 → mozilla2.0b11
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: