629461 - Personas detail page in discovery pane

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[krupa raj[:krupa]]

Right now, persona details page in disco pane looks exactly like extension detail pages. See https://addons.allizom.org/en-US/firefox/discovery/addon/japanese-tattoo/

We need mocks for how they ought to look.

Comment 1

[Wil Clouser [:clouserw]]

Did you talk to fligtar about this?  I'm not sure there will be persona detail pages and was waiting on him to file his bug before this one.

Comment 2

[krupa raj[:krupa]]

(In reply to comment #1)
> Did you talk to fligtar about this?  I'm not sure there will be persona detail
> pages and was waiting on him to file his bug before this one.

I did. He told me to ask chowse.

Comment 3

[Justin Scott [:fligtar]]

and then I flew away on my broom cackling

Comment 4

[Chris Howse [:chowse]]

Attachment: Persona Detail Mock-up

Notes:

* The preview image is 680x100 max. If the window is not wide enough to fit
  this, crop the image from the left (i.e. the rightmost edge should always
  be visible).

* Hovering over the preview image should apply the persona temporarily, the
  same as on AMO/GetPersonas.

* The 'Hover to Preview' decal is there since we apparently don't do
  hover-to-preview on the main DiscoPane page. If this is a bug or error,
  feel free to remove the decal.

* I didn't include reviews, but they will not differ from reviews on an
  extension detail page.

Comment 5

[Wil Clouser [:clouserw]]

Thanks chowse.

> * The 'Hover to Preview' decal is there since we apparently don't do
>   hover-to-preview on the main DiscoPane page. If this is a bug or error,
>   feel free to remove the decal.

I don't think we need the decal, the hover-to-preview is on the main page (but is apparently broken in the latest nightly).  fligtar says it works in b11 though.

Comment 6

[Christopher Van Wiemeersch [:cvan]]

Committed: https://github.com/jbalogh/zamboni/commit/f1521e5

Comment 7

[Wil Clouser [:clouserw]]

That looks much better!

Comment 8

[krupa raj[:krupa]]

Attachment: screenshot

In the mock-up, the install/learn more buttons are below the persona preview. In the actual implementation, they are above the preview.

Does that matter?

Comment 9

[Justin Scott [:fligtar]]

I do prefer the visual flow of the Persona being on top. Seems like we also might be missing the 'hover to preview' and author link.

Comment 10

[krupa raj[:krupa]]

 
> Seems like we also might be missing the 'hover to preview' and author link.

personas do not have author link. See https://addons.allizom.org/en-US/firefox/addon/romantic-278105-2/

Comment 11

[krupa raj[:krupa]]

reopening based on comment 9

Comment 12

[Christopher Van Wiemeersch [:cvan]]

(In reply to comment #8)
> In the mock-up, the install/learn more buttons are below the persona preview.
> In the actual implementation, they are above the preview.

http://people.mozilla.com/~chowse/drop/amo/discovery/v2/01_Addon_Detail.png

The mockup for the Add-on detail view for regular add-ons shows the gallery below the description + install buttons. But the mockup for the Persona detail view shows the preview image below the description. Shall I stick to the mockups or move both of them above the description?

Comment 13

[Justin Scott [:fligtar]]

Add-on screenshots and the actual Persona are different, so I don't see why they have to stick together.

Comment 14

[Chris Howse [:chowse]]

(In reply to comment #13)
> Add-on screenshots and the actual Persona are different, so I don't see why
> they have to stick together.

Agreed. For extensions, the screenshots are supplemental: you could read the description alone and that might be sufficient to decide if you want to install it. For Personas, the preview is primary: you won't decide to install it until you've seen what it looks like. So having the Persona preview above the install button is important, but having extension screenshots below the install button is acceptable.

Comment 15

[Christopher Van Wiemeersch [:cvan]]

Updated: https://github.com/jbalogh/zamboni/commit/dffb52c

Comment 16

[krupa raj[:krupa]]

(In reply to comment #15)
> Updated: https://github.com/jbalogh/zamboni/commit/dffb52c

This needs to be pushed to next.

Comment 17

[krupa raj[:krupa]]

verified fixed @ https://addons-next.allizom.org/en-US/firefox/discovery/addon/japanese-tattoo/?src=discovery-top

Comment 18

[krupa raj[:krupa]]

Attachment: post-fix screenshot