Closed
Bug 629489
Opened 13 years ago
Closed 13 years ago
Update mozStorage.h on how to add more errors
Categories
(Toolkit :: Storage, defect)
Toolkit
Storage
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: sdwilsh, Assigned: ally)
Details
(Whiteboard: [good first bug])
Attachments
(1 file, 1 obsolete file)
1.51 KB,
patch
|
Details | Diff | Splinter Review |
We need a comment here on how to add more errors. Not only do we need to add it to mozStorage.h, but we also need to update this spot: https://hg.mozilla.org/mozilla-central/annotate/e98b94aa64fa/js/src/xpconnect/src/xpc.msg#l220
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #525150 -
Flags: review?(sdwilsh)
Reporter | ||
Updated•13 years ago
|
Assignee: nobody → a.m.naaktgeboren
Status: NEW → ASSIGNED
Reporter | ||
Comment 2•13 years ago
|
||
Comment on attachment 525150 [details] [diff] [review] proposed patch #1 >+++ b/storage/public/mozStorage.h >+/* >+ * To add additional errors to Storage, please append entries to the bottom of >+ * the list in the following format: >+ * '#define NS_ERROR_STORAGE_YOUR_ERR NS_ERROR_GENERATE_FAILURE( >+ * NS_ERROR_MODULE_STORAGE, n)' What about formatting this like it is down below? Something like: >+ * '#define NS_ERROR_STORAGE_YOUR_ERROR \ >+ * NS_ERROR_GENERATE_FAILURE(NS_ERROR_MODULE_STORAGE, n)' r=sdwilsh with this comment addressed!
Attachment #525150 -
Flags: review?(sdwilsh) → review+
Reporter | ||
Comment 4•13 years ago
|
||
Since I'm doing a merge soon anyway... http://hg.mozilla.org/projects/places/rev/e72813d821b8
Whiteboard: [good first bug] → [fixed-in-places][good first bug]
Reporter | ||
Comment 5•13 years ago
|
||
Congratulations on getting your first piece of code into the tree! http://hg.mozilla.org/mozilla-central/rev/e72813d821b8
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [fixed-in-places][good first bug] → [good first bug]
Target Milestone: --- → mozilla2.2
Reporter | ||
Comment 6•13 years ago
|
||
toolkit/components/places/tests/expiration/test_analyze_runs.js may be busted with this patch (based on try results).
You need to log in
before you can comment on or make changes to this bug.
Description
•