Update mozStorage.h on how to add more errors

RESOLVED FIXED in mozilla5

Status

()

Toolkit
Storage
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: sdwilsh, Assigned: ally)

Tracking

Trunk
mozilla5
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
We need a comment here on how to add more errors.  Not only do we need to add it to mozStorage.h, but we also need to update this spot:
https://hg.mozilla.org/mozilla-central/annotate/e98b94aa64fa/js/src/xpconnect/src/xpc.msg#l220
(Assignee)

Comment 1

7 years ago
Created attachment 525150 [details] [diff] [review]
proposed patch #1
Attachment #525150 - Flags: review?(sdwilsh)
(Reporter)

Updated

7 years ago
Assignee: nobody → a.m.naaktgeboren
Status: NEW → ASSIGNED
(Reporter)

Comment 2

7 years ago
Comment on attachment 525150 [details] [diff] [review]
proposed patch #1

>+++ b/storage/public/mozStorage.h
>+/*
>+ * To add additional errors to Storage, please append entries to the bottom of 
>+ * the list in the following format: 
>+ * '#define NS_ERROR_STORAGE_YOUR_ERR NS_ERROR_GENERATE_FAILURE(
>+ * NS_ERROR_MODULE_STORAGE, n)'
What about formatting this like it is down below?  Something like:
>+ * '#define NS_ERROR_STORAGE_YOUR_ERROR \
>+ *    NS_ERROR_GENERATE_FAILURE(NS_ERROR_MODULE_STORAGE, n)'

r=sdwilsh with this comment addressed!
Attachment #525150 - Flags: review?(sdwilsh) → review+
(Assignee)

Comment 3

7 years ago
Created attachment 525157 [details] [diff] [review]
approved patch

approved patch
Attachment #525150 - Attachment is obsolete: true
(Reporter)

Comment 4

7 years ago
Since I'm doing a merge soon anyway...
http://hg.mozilla.org/projects/places/rev/e72813d821b8
Whiteboard: [good first bug] → [fixed-in-places][good first bug]
(Reporter)

Comment 5

7 years ago
Congratulations on getting your first piece of code into the tree!

http://hg.mozilla.org/mozilla-central/rev/e72813d821b8
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [fixed-in-places][good first bug] → [good first bug]
Target Milestone: --- → mozilla2.2
(Reporter)

Comment 6

7 years ago
toolkit/components/places/tests/expiration/test_analyze_runs.js may be busted with this patch (based on try results).
You need to log in before you can comment on or make changes to this bug.