629489 - Update mozStorage.h on how to add more errors

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Shawn Wilsher :sdwilsh]

We need a comment here on how to add more errors.  Not only do we need to add it to mozStorage.h, but we also need to update this spot:
https://hg.mozilla.org/mozilla-central/annotate/e98b94aa64fa/js/src/xpconnect/src/xpc.msg#l220

Comment 1

[Allison Naaktgeboren :ally]

Attachment: proposed patch #1

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 525150 [details] [diff] [review]
proposed patch #1

>+++ b/storage/public/mozStorage.h
>+/*
>+ * To add additional errors to Storage, please append entries to the bottom of 
>+ * the list in the following format: 
>+ * '#define NS_ERROR_STORAGE_YOUR_ERR NS_ERROR_GENERATE_FAILURE(
>+ * NS_ERROR_MODULE_STORAGE, n)'
What about formatting this like it is down below?  Something like:
>+ * '#define NS_ERROR_STORAGE_YOUR_ERROR \
>+ *    NS_ERROR_GENERATE_FAILURE(NS_ERROR_MODULE_STORAGE, n)'

r=sdwilsh with this comment addressed!

Comment 3

[Allison Naaktgeboren :ally]

Attachment: approved patch

approved patch

Comment 4

[Shawn Wilsher :sdwilsh]

Since I'm doing a merge soon anyway...
http://hg.mozilla.org/projects/places/rev/e72813d821b8

Comment 5

[Shawn Wilsher :sdwilsh]

Congratulations on getting your first piece of code into the tree!

http://hg.mozilla.org/mozilla-central/rev/e72813d821b8

Comment 6

[Shawn Wilsher :sdwilsh]

toolkit/components/places/tests/expiration/test_analyze_runs.js may be busted with this patch (based on try results).