629498 - mobile build factories need to use hg try lock

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris AtLee [:catlee]]

We have a lock in http://hg.mozilla.org/build/buildbotcustom/file/3871c7cbe41d/process/factory.py#l67 that prevents hoards of try builders from overloading hg.m.o.  Currently the mobile builders on try don't use this lock.

Comment 1

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: buildbotcustom-v1

This has passed ./test-masters -8 locally.

Comment 2

[Chris AtLee [:catlee]]

Comment on attachment 507624 [details] [diff] [review]
buildbotcustom-v1

Needs to be applied only to try branch

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to comment #2)
> Comment on attachment 507624 [details] [diff] [review]
> buildbotcustom-v1
> 
> Needs to be applied only to try branch

this patch does only apply to the try branch.  It is in a section that is specific to try.

Comment 4

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: patch that shows that this is specific to try

new patch that shows they try-only nature of this change.

Comment 5

[Chris AtLee [:catlee]]

Comment on attachment 508792 [details] [diff] [review]
patch that shows that this is specific to try

yay!

Comment 6

[Aki Sasaki (not active)]

This landed as part of http://hg.mozilla.org/build/buildbotcustom/rev/119176006f3e .

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

per comment 6, and because we have merged the code that this touched with existing try infrastructure.