Closed
Bug 629550
Opened 14 years ago
Closed 14 years ago
Audit uses of |safe in templates
Categories
(Input :: General, defect, P2)
Input
General
Tracking
(Not tracked)
VERIFIED
FIXED
3.1
People
(Reporter: wenzel, Assigned: wenzel)
Details
(Whiteboard: [qa-])
Per the playdoh best practices[1], |safe should be used very sparingly. Need to audit the places where we use it in Input and remove any possibly unsafe uses.
|
Assignee | |
Comment 1•14 years ago
|
||
Belated footnote:
[1] http://mozilla.github.com/playdoh/bestpractices/#safe-considered-harmful
|
|
Assignee | |
Comment 2•14 years ago
|
||
I fixed the two instances of |f()|safe that I found with the new |fe() helper.
http://github.com/fwenzel/reporter/commit/509f9f3
When work on bug 627449 is done, we should revisit this and remove all instances of |safe from form fields, but that's no longer a security issue.
This is [qa-] as it is an internal-code-only thing.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
|
||
Updated•14 years ago
|
Component: Input → General
Product: Webtools → Input
You need to log in
before you can comment on or make changes to this bug.
Description
•