Closed Bug 629576 Opened 9 years ago Closed 9 years ago

MOZ_NATIVE_SQLITE is not defined for C++ code

Categories

(Toolkit :: Storage, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

Details

Attachments

(3 files)

/storage/src/SQLiteMutex.h
line 86 -- #if !defined(DEBUG) || defined(MOZ_NATIVE_SQLITE)

We didn't do AC_DEFINE for MOZ_NATIVE_SQLITE.
So compiling debug build of Firefox with native release build libsqlite will fail.
Attached patch patchSplinter Review
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #512105 - Flags: review?
Attachment #512105 - Flags: review? → review?(sdwilsh)
Attachment #512105 - Flags: review?(sdwilsh) → review?(khuey)
Comment on attachment 512105 [details] [diff] [review]
patch

Add the 'fi'.

r=me with that
Attachment #512105 - Flags: review?(khuey) → review+
Attached patch patch revisedSplinter Review
http://hg.mozilla.org/projects/cedar/rev/b26a6eda6f8b
Whiteboard: fixed-in-cedar
Attachment #523250 - Flags: review?(bugspam.Callek)
http://hg.mozilla.org/mozilla-central/rev/b26a6eda6f8b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla2.2
Attachment #523250 - Flags: review?(bugspam.Callek) → review+
You need to log in before you can comment on or make changes to this bug.