629588 - Collection icons occasionally are served with .png missing in their paths, and are broken/404

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Something's eating our Collections images on the Collections landing page:

https://addons.mozilla.org/en-US/firefox/collections/

Note that they show up, here:
https://addons.mozilla.org/en-US/firefox/collections/mozilla/webdeveloper/
https://addons.mozilla.org/en-US/firefox/collections/mozilla/travel/
etc.

The working icon URL for, e.g. the Web Developer's Toolbox: https://addons.mozilla.org/en-US/firefox/images/collection_icon/2.png?modified=1296169397

Broken one: https://addons.mozilla.org/en-US/firefox/images/collection_icon/2/1296169397

Looks like we just are missing adding the ?modified=[timestamp/whatever] param.

(And yes, Jeff, this is a regression.)

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Odd, odd bug; seems to be easier to reproduce while logged out, which might indicate caching?

Comment 2

[Jeff Balogh (:jbalogh)]

(In reply to comment #0)
> Something's eating our Collections images on the Collections landing page:
> 
> https://addons.mozilla.org/en-US/firefox/collections/
> 
> Note that they show up, here:
> https://addons.mozilla.org/en-US/firefox/collections/mozilla/webdeveloper/
> https://addons.mozilla.org/en-US/firefox/collections/mozilla/travel/
> etc.
> 
> The working icon URL for, e.g. the Web Developer's Toolbox:
> https://addons.mozilla.org/en-US/firefox/images/collection_icon/2.png?modified=1296169397
> 
> Broken one:
> https://addons.mozilla.org/en-US/firefox/images/collection_icon/2/1296169397

This is peculiar since https://addons.mozilla.org/z/en-US/admin/settings#collection_icon_url indicates the correct template.

> Looks like we just are missing adding the ?modified=[timestamp/whatever] param.

icon/:id.png is actually the key.

> (And yes, Jeff, this is a regression.)

And how!

I cleared the cache and this looks fine.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

I'm glad it works for you; too bad it doesn't continue to work for me, consistently:

[20:09:27.077] GET https://addons.mozilla.org/en-US/firefox/collections/ [HTTP/1.1 200 OK 213ms]
[20:09:27.368] GET https://addons.mozilla.org/media//css/zamboni/css-min.css?build=97b6f9f [HTTP/1.1 304 Not Modified 106ms]
[20:09:27.402] GET https://addons.mozilla.org/en-US/firefox/images/collection_icon/2/1296169397 [HTTP/1.1 404 Not Found 571ms]
[20:09:27.428] GET https://addons.mozilla.org/en-US/firefox/images/collection_icon/4/1296119786 [HTTP/1.1 404 Not Found 532ms]
[20:09:27.454] GET https://addons.mozilla.org/en-US/firefox/images/collection_icon/6/1294413536 [HTTP/1.1 404 Not Found 501ms]
[20:09:27.479] GET https://addons.mozilla.org/en-US/firefox/images/collection_icon/10/1295660154 [HTTP/1.1 404 Not Found 511ms]
[20:09:27.505] GET https://addons.mozilla.org/en-US/firefox/images/collection_icon/54/1296085747 [HTTP/1.1 404 Not Found 556ms]
[20:09:27.529] GET https://addons.mozilla.org/en-US/firefox/images/collection_icon/33357/1294636520 [HTTP/1.1 404 Not Found 977ms]
[20:09:27.555] GET https://addons.mozilla.org/en-US/firefox/images/collection_icon/37265/1294318849 [HTTP/1.1 404 Not Found 1095ms]

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot -- still happening, no matter what jbalogh attests

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

http://screencast.com/t/pgq6NSXtjC, because I *know* just how much you adore screencasts.

I've removed the regression keyword, since of course I can't "prove" it is a regression from code; but, something's obviously up, and it occurs on different Zeus instances, as well as AMO backend servers.  Again, when it's broken, the served HTML is missing the .png file extension (as you rightly pointed out, above).

Comment 6

[Wil Clouser [:clouserw]]

Heh, alright you two.  I don't think either of you are lying. :)

We changed the collection icon format with our last push, so the old format was probably stuck in a cache somewhere or it didn't sync out to all the servers right away.

I poked around on all the pages and didn't see this today so I'm going to close it as fixed.

I did come across a few collections that are missing their icons - but that's because it's actually a 404, the URL is right, just the file is missing (I don't know why).  eg: https://addons.mozilla.org/en-US/firefox/collections/webilu/webpro/ and https://addons.mozilla.org/en-US/firefox/collections/williamlong/list/

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

With the exceptions noted in commet 6, this does indeed look like it worked itself out; sorry for the back-and-forth while I was still experiencing the issue.

Verified FIXED.