629599 - [traceback] ValueError: invalid literal for int() with base 10: '*' in Discovery Pane API

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Discovery Pane, defect, P4)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Not sure if this is the caller (search), or higher up (handler), but https://services.addons.mozilla.org/en-US/firefox/discovery/pane/4.0*/WINNT and https://addons.allizom.org/en-US/firefox/discovery/pane/4.0*/WINNT trigger:

Traceback (most recent call last):

  File "/data/amo_python/www/services.prod/zamboni/vendor/src/django/django/core/handlers/base.py", line 109, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/amo_python/www/services.prod/zamboni/apps/discovery/views.py", line 43, in pane
    'top_addons': from_api('by_adu'),

  File "/data/amo_python/www/services.prod/zamboni/apps/discovery/views.py", line 32, in from_api
    r = api_view(request, platform, version, list_type)

  File "/data/amo_python/www/services.prod/zamboni/apps/discovery/views.py", line 75, in api_view
    version=version)

  File "/data/amo_python/www/services.prod/zamboni/apps/api/views.py", line 274, in process_request
    return cached_with(addons, f, map(encoding.smart_str, args))

  File "/data/amo_python/www/services.prod/zamboni/vendor/src/django-cache-machine/caching/base.py", line 282, in cached_with
    return cached(f, key, timeout)

  File "/data/amo_python/www/services.prod/zamboni/vendor/src/django-cache-machine/caching/base.py", line 262, in cached
    val = function()

  File "/data/amo_python/www/services.prod/zamboni/apps/api/views.py", line 273, in <lambda>
    f = lambda: self._process(addons, *args)

  File "/data/amo_python/www/services.prod/zamboni/apps/api/views.py", line 278, in _process
    {'addons': addon_filter(addons, *args)})

  File "/data/amo_python/www/services.prod/zamboni/apps/api/views.py", line 116, in addon_filter
    v = search_utils.convert_version(version)

  File "/data/amo_python/www/services.prod/zamboni/apps/search/utils.py", line 93, in convert_version
    minor2 = int(minor2 or 0)

ValueError: invalid literal for int() with base 10: '*'

Comment 1

[Wil Clouser [:clouserw]]

I don't think that's a valid URL, but that argument shouldn't crash either.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

'HTTP_USER_AGENT': 'Mozilla/5.0 (Windows NT 6.1; rv:2.0b12pre) Gecko/20110211 Firefox/4.0*', is what's requesting this, looking at the info in the traceback, if that helps; I don't know what that is, though.

Comment 3

[Wil Clouser [:clouserw]]

Yeah, I haven't heard of it either and it doesn't get many hits, I assume it's just some guy who messed with his UA.  Even if we don't crash, we wouldn't have any results to send him, so still low priority.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

https://github.com/jbalogh/zamboni/commit/7af7a6c

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://addons.allizom.org/en-US/firefox/discovery/pane/4.0*/WINNT.