629612 - non-libxul builds broken because of incorrect code committed in bug 628922

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[(no longer active)]

/Users/ehsanakhgari/moz/mozilla-central/layout/base/nsPresShell.cpp: In static member function ‘static nsAccessibilityService* nsIPresShell::AccService()’:
/Users/ehsanakhgari/moz/mozilla-central/layout/base/nsPresShell.cpp:9266: error: invalid static_cast from type ‘nsCOMPtr<nsIAccessibilityService>’ to type ‘nsAccessibilityService*’

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[alexander :surkov (:asurkov)]

(In reply to comment #1)
> Created attachment 507799 [details] [diff] [review]
> Patch (v1)

this patch is expecting review in bug 628922.
btw, David is not a peer of layout module, you can't ask his review here.

Comment 3

[alexander :surkov (:asurkov)]

Ehsan, you can r+ it then I'll land it asap.

Comment 4

[Marco Zehe (:MarcoZ)]

Comment on attachment 507799 [details] [diff] [review]
Patch (v1)

I believe Surkov already committed a bustage fix for Roc's review in bug 628922 that is exactly the same as this one.

Comment 5

[alexander :surkov (:asurkov)]

(In reply to comment #4)
> Comment on attachment 507799 [details] [diff] [review]
> Patch (v1)
> 
> I believe Surkov already committed a bustage fix for Roc's review in bug 628922
> that is exactly the same as this one.

right.

Comment 6

[alexander :surkov (:asurkov)]

fixed by bug 628922

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 507799 [details] [diff] [review]
Patch (v1)

A little late, but r+ anyways. Thanks!