629686 - Port bug 620837 - Modify blocklist pingCount parameter to track pingCount for profile and for version

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Mark Banner (:standard8)]

We just need to add a couple more parameters to get better tracking. I'll attach a patch a bit later.

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix

This just copies across the necessary change to the blocklist url.

Comment 2

[Rain [:rain1] (inactive)]

Comment on attachment 508383 [details] [diff] [review]
The fix

I think after Firefox 4 we should look at getting the extension prefs into a common location so that we don't have to copy over every change to them.

Comment 3

[Robert Strong (they/them - no direct email)]

(In reply to comment #2)
> Comment on attachment 508383 [details] [diff] [review]
> The fix
> 
> I think after Firefox 4 we should look at getting the extension prefs into a
> common location so that we don't have to copy over every change to them.
This would be fine as long as you are fine with picking up changes that you *might* not actually want.

Comment 4

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/bbfc217dd3ff

I think merging some of the toolkit preferences into one file might be a good idea to think about later, but we may have to take them on a case-by-case basis, which might actually make it too complex.

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #4)
> Checked in: http://hg.mozilla.org/comm-central/rev/bbfc217dd3ff

Make that http://hg.mozilla.org/comm-central/rev/dd85cfec5252