629719 - Experiment with turning the UNREASONABLE_WORD_LENGTH limit for spell checker off in the nightlies

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[(no longer active)]

We should see if turning off the protection added in bug 340050 still causes crashes...

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Maybe Jesse or Martijn could try out some evil tests.

Comment 3

[(no longer active)]

(In reply to Olli Pettay [:smaug] from comment #2)
> Maybe Jesse or Martijn could try out some evil tests.

I'd love that, yes!

Comment 4

[Mounir Lamouri (:mounir)]

http://hg.mozilla.org/mozilla-central/rev/3f728ae0066c

Comment 5

[Martijn Wargers (dead)]

I don't know in what circumstances you would think it would crash. On long words, with the patch, it doesn't seem to crash anymore. But with the testcase from bug 334814, https://bugzilla.mozilla.org/attachment.cgi?id=219142 , it's still causing Mozilla to hang, having to kill it manually.

Comment 6

[(no longer active)]

(In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #5)
> I don't know in what circumstances you would think it would crash. On long
> words, with the patch, it doesn't seem to crash anymore. But with the
> testcase from bug 334814,
> https://bugzilla.mozilla.org/attachment.cgi?id=219142 , it's still causing
> Mozilla to hang, having to kill it manually.

I can't reproduce that.  If you see this reliably, please file a new bug and include the STR.  Thanks!

Comment 7

[Martijn Wargers (dead)]

Ok, I filed bug 686497.

Comment 8

[Eric Shepherd [:sheppy]]

This change has been listed in Firefox 9 for developers; the removed limitation had not been documented.