The default bug view has changed. See this FAQ.

Experiment with turning the UNREASONABLE_WORD_LENGTH limit for spell checker off in the nightlies

RESOLVED FIXED

Status

()

Core
Spelling checker
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

({dev-doc-complete})

Trunk
x86
Mac OS X
dev-doc-complete
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
We should see if turning off the protection added in bug 340050 still causes crashes...
(Assignee)

Comment 1

6 years ago
Created attachment 554108 [details] [diff] [review]
Patch (v1)
Attachment #554108 - Flags: review?(Olli.Pettay)
Attachment #554108 - Flags: review?(Olli.Pettay) → review+
Maybe Jesse or Martijn could try out some evil tests.
(Assignee)

Comment 3

6 years ago
(In reply to Olli Pettay [:smaug] from comment #2)
> Maybe Jesse or Martijn could try out some evil tests.

I'd love that, yes!
(Assignee)

Updated

6 years ago
Keywords: dev-doc-needed
Whiteboard: [post-2.0]
http://hg.mozilla.org/mozilla-central/rev/3f728ae0066c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite?
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
I don't know in what circumstances you would think it would crash. On long words, with the patch, it doesn't seem to crash anymore. But with the testcase from bug 334814, https://bugzilla.mozilla.org/attachment.cgi?id=219142 , it's still causing Mozilla to hang, having to kill it manually.
OS: All → Mac OS X
Hardware: All → x86
Target Milestone: mozilla9 → ---
(Assignee)

Comment 6

6 years ago
(In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #5)
> I don't know in what circumstances you would think it would crash. On long
> words, with the patch, it doesn't seem to crash anymore. But with the
> testcase from bug 334814,
> https://bugzilla.mozilla.org/attachment.cgi?id=219142 , it's still causing
> Mozilla to hang, having to kill it manually.

I can't reproduce that.  If you see this reliably, please file a new bug and include the STR.  Thanks!

Updated

6 years ago
Depends on: 686497
Ok, I filed bug 686497.
This change has been listed in Firefox 9 for developers; the removed limitation had not been documented.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.