629764 - Make admin search better - add a results page

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P4)

Description

[Andrew Williamson [:eviljeff]]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b10) Gecko/20100101 Firefox/4.0b10
Build Identifier: 

The admin search needs to be better, especially with the Zamboni changes making every rejected addon invisible to the public search.  

The current function works okay if you know exactly what the addon is called, and its not called something common.  Otherwise the wrong addon is matched and you have to resort to trying combinations of words to get something that looks right to pop up in the short list of search suggestions...

For a start I'd suggest replacing the current JSON search suggestion in the search box & "I'm feeling lucky" style result returned with a full list of search results.

The code must be mostly there for the search suggestion already and it doesn't need to be pretty - a list of urls would do imo.   

Reproducible: Always

Comment 1

[Wil Clouser [:clouserw]]

Since you're doing the other pages in ES, this might be somewhat easy.  If not, at least think about it (ie. we'll need to show disabled add-ons, etc.)

Comment 2

[Wil Clouser [:clouserw]]

You're doing a bunch of ES stuff already, so let's grab this page too:

    https://addons.mozilla.org/en-US/admin/addons

Search results should include disabled, unreviewed, etc.  We can come up with banners to differentiate them at some point unless you make it easy here.  I wouldn't object to keeping the autocomplete in addition to "real" search results.  The collection add-on adder (!) already uses autocomplete if that helps you here.

Comment 3

[Andrew Williamson [:eviljeff]]

Can I ask that the search match old style addon ID's as well as the new slugs?  Some things still use the old ID (MXRfor example).

Comment 4

[Jeff Balogh (:jbalogh)]

https://github.com/jbalogh/zamboni/commit/3e16ed2 

Use this page for searching:

https://addons.allizom.org/z/en-US/admin/addon-search

I can't fully replace the old and busted page because we don't have all that admin stuff in zamboni yet. This new search page will bounce you over to PHP if there's only one result, or it will show a bunch of URLs if there are multiple matches.

You can search for names or ids. Send patches if you hate the UI too much.

Comment 5

[Andrew Williamson [:eviljeff]]

Excellent, I've had a quick play and the UI is pretty much what I was expecting - I can file bugs to add niceties later.

The search isn't working properly for me though, (unless there is a specical syntax I'm not aware of) - its only matching addons where the name starts with the string.

For example, search for 'youtube' returns a number of matches, one of them 'youtube cinema'; a search for 'cinema' doesn't return 'youtube cinema' among the matches.

Also, you've limited the matches to 25 but there isn't a link to get to the next 25.  (at least 100 would be better anyway!).  I can file this as a separate bug if you'd prefer.

Comment 6

[Jeff Balogh (:jbalogh)]

(In reply to comment #5)
> The search isn't working properly for me though, (unless there is a specical
> syntax I'm not aware of) - its only matching addons where the name starts
> with the string.
> 
> For example, search for 'youtube' returns a number of matches, one of them
> 'youtube cinema'; a search for 'cinema' doesn't return 'youtube cinema'
> among the matches.

That was by design. The way I expected this to work was that you knew the name and just wanted a prefix match.
 
> Also, you've limited the matches to 25 but there isn't a link to get to the
> next 25.  (at least 100 would be better anyway!).  I can file this as a
> separate bug if you'd prefer.

I thought 25 was generous, since I would just refine the search if it wasn't in the first couple results.

Can you file new bugs for these and other issues you find? The current implementation works for me but I'm not the target audience.