629781 - BBC's image views don't work because of racy interdependencies between script-inserted external scripts

Status: RESOLVED WORKSFORME

(Web Compatibility :: Site Reports, defect)

Description

[(no longer active)]

See <http://www.bbc.co.uk/arabic/middleeast/2011/01/110128_egypt_friday_gellery.shtml>.  You should see images instead of the large blank area in the middle of the screen.  Here's what the js error looks like:

[16:36:47.253] h.widgets is undefined @ http://node1.bbcimg.co.uk/glow/glow/1.7.3/widgets/widgets.js:18

This page works fine in 3.6.

Comment 1

[Andreas Gal :gal]

This looks very similar to the error Gary reported on an asian news site.

Comment 2

[David Mandelin [:dmandelin]]

(In reply to comment #1)
> This looks very similar to the error Gary reported on an asian news site.

Namely, bug 629622.

Comment 3

[(no longer active)]

I noticed that if I try hard enough (i.e, press Cmd+R or Cmd+Shift+R enough times) the images show up.  This makes finding the regression range quite hard...

Comment 4

[(no longer active)]

This is what I get when loading the page from my debug build:

++DOMWINDOW == 19 (0x129261da8) [serial = 31] [outer = 0x1344ed030]
WARNING: No script language registered for this mime-type: file /Users/ehsanakhgari/moz/mozilla-central/dom/base/nsDOMScriptObjectFactory.cpp, line 160
WARNING: The script-type is unknown: file /Users/ehsanakhgari/moz/mozilla-central/content/base/src/nsDocument.cpp, line 3107
WARNING: Not same origin error!: file /Users/ehsanakhgari/moz/mozilla-central/dom/base/nsJSEnvironment.cpp, line 425
JavaScript error: http://node1.bbcimg.co.uk/glow/glow/1.7.3/widgets/widgets.js, line 18: h.widgets is undefined
WARNING: Unable to test style tree integrity -- no content node: file /Users/ehsanakhgari/moz/mozilla-central/layout/base/nsCSSFrameConstructor.cpp, line 8060
WARNING: Unable to test style tree integrity -- no content node: file /Users/ehsanakhgari/moz/mozilla-central/layout/base/nsCSSFrameConstructor.cpp, line 8060
WARNING: Unable to test style tree integrity -- no content node: file /Users/ehsanakhgari/moz/mozilla-central/layout/base/nsCSSFrameConstructor.cpp, line 8060

Don't know which parts are relevant...

Comment 5

[(no longer active)]

And this, when the images show up successfully:

++DOMWINDOW == 19 (0x1292b6268) [serial = 32] [outer = 0x1344ed030]
WARNING: No script language registered for this mime-type: file /Users/ehsanakhgari/moz/mozilla-central/dom/base/nsDOMScriptObjectFactory.cpp, line 160
WARNING: The script-type is unknown: file /Users/ehsanakhgari/moz/mozilla-central/content/base/src/nsDocument.cpp, line 3107
WARNING: Unable to test style tree integrity -- no content node: file /Users/ehsanakhgari/moz/mozilla-central/layout/base/nsCSSFrameConstructor.cpp, line 8060
WARNING: Unable to test style tree integrity -- no content node: file /Users/ehsanakhgari/moz/mozilla-central/layout/base/nsCSSFrameConstructor.cpp, line 8060

At first I thought the number of "Unable to test style tree integrity" warnings are significant, but I also got runs with only two of them which failed to load the images...

Comment 6

[David Mandelin [:dmandelin]]

I get this regression range from TM nightlies:

http://hg.mozilla.org/tracemonkey/pushloghtml?fromchange=98c134cf59ef&tochange=6ff07c1f4dc2

Comment 7

[Bill Gianopoulos [:WG9s]]

Oddly, the pages look just fine with today's build under Linux.

Comment 8

[Bill Gianopoulos [:WG9s]]

Is this OSX only?

Comment 9

[David Mandelin [:dmandelin]]

(In reply to comment #8)
> Is this OSX only?

I repro'd it on Win 7.

Comment 10

[David Mandelin [:dmandelin]]

I narrowed the range to:

http://hg.mozilla.org/tracemonkey/pushloghtml?fromchange=f8a4a5f68942&tochange=cd8b5689ffbf

There's only one JS patch in that range, and it's a very unlikely candidate. I'm almost certain this is the patch that caused the regression:

http://hg.mozilla.org/tracemonkey/rev/a60414d076b5

changeset:   54680:a60414d076b5
user:        Henri Sivonen <[e-mail]>
date:        Wed Sep 01 14:41:12 2010 +0300
summary:     Bug 591981 - Make script-inserted inline scripts run right away, make script-inserted external scripts behave like async scripts and make document.write writing an inline script return at a predictable time. r=jonas, a=blocking2.0-beta7.

A key piece of evidence is that the linked URL fails in the same way in Chrome, and bug 591981 comment 0 says that bug brings Fx in line with HTML5 and other browsers. Looks like an evangelism issue to me.

Comment 11

[Henri Sivonen (:hsivonen)]

I don't see the problem, but that doesn't mean it's fixed, because the HTTP requests may finish in a different order for me.

If the problem persists, I suggest pointing the BBC to http://hsivonen.iki.fi/script-execution/

Comment 12

[Karl Dubost💡 :karlcow]

tested on Firefox 31, and Safari.
Working for me.