629809 - AttributeError: 'module' object has no attribute 'ERROR'

Status: RESOLVED FIXED

(Cloud Services :: Server: Other, defect)

Description

[:Atoll]

I tried to reset the password of an account name I made up out of thin air, that may or may not exist, but I exposed a code bug instead:

2011-01-28 15:36:19,875 ERROR [accountportal] Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/services/util.py", line 427, in __call__
    return self.app(environ, start_response)
  File "/usr/lib/python2.6/site-packages/beaker/middleware.py", line 152, in __call__
    return self.wrap_app(environ, session_start_response)
  File "/usr/lib/python2.6/site-packages/webob/dec.py", line 147, in __call__
    resp = self.call_func(req, *args, **self.kwargs)
  File "/usr/lib/python2.6/site-packages/webob/dec.py", line 208, in call_func
    return self.func(req, *args, **kwargs)
  File "/usr/lib/python2.6/site-packages/accountportal/wsgiapp.py", line 163, in __call__
    result = function(request, **params)
  File "/usr/lib/python2.6/site-packages/accountportal/controllers/console.py", line 104, in forgot
    user_id = self.auth.get_user_id(username)
  File "/usr/lib/python2.6/site-packages/services/auth/ldapsql.py", line 194, in get_user_id
    return None
  File "/usr/lib64/python2.6/contextlib.py", line 34, in __exit__
    self.gen.throw(type, value, traceback)
  File "/usr/lib/python2.6/site-packages/services/auth/ldappool.py", line 184, in connection
    yield conn
  File "/usr/lib/python2.6/site-packages/services/auth/ldapsql.py", line 190, in get_user_id
    except (ldap.TIMEOUT, ldap.ERROR, ldap.OTHER), e:
AttributeError: 'module' object has no attribute 'ERROR'

Comment 1

[Toby Elliott [:telliott]]

reassigning to Tarek, but I'm about to propose pulling change_email from the account portal anyway

Comment 2

[Tarek Ziadé (:tarek)]

well that's still an issue in any case -- fixing it now

Comment 4

[Tarek Ziadé (:tarek)]

Attachment: Fixes the ERROR and username undefined names error

This patch fixes the ERROR issue, and also the error found in bug 632335. All parts are now covered by the tests I have added.

This patch also removes duplicate patching code in the tests.

Comment 5

[JR Conlin [:jrconlin,:jconlin]]

Comment on attachment 511668 [details] [diff] [review]
Fixes the ERROR and username undefined names error

looks good

Comment 6

[Tarek Ziadé (:tarek)]

Commited in http://hg.mozilla.org/services/server-core/rev/729c538969e4