629815 - macosx/universal/mozconfig.common should not select the compiler

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: don't select the compiler

macosx/universal/mozconfig.common forces the compiler to be gcc 4.2. This looks unnecessary and prevents building with clang.

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Use gcc-4.2 if CC is not set

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 508032 [details] [diff] [review]
Use gcc-4.2 if CC is not set

I was going to originally say that the universal build config is very specific to what we support on tinderbox, but as implemented this patch is fine. Given your latest posts I'd be interested in trying Clang on our official builds in the near future.

Comment 3

[(not currently active) Ted Mielczarek]

I don't see the point in taking this on trunk, we're not going to ship Firefox 4 with clang. We can take it after we ship.

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: updated patch

This patch also move the test for NATIVE_CPU before we change CC and CXX. This is a bug in the current file, but it only causes problem with xcode4's linker.

In 3.2.5 mbsdiff ends up being linked with the system bz2. With 4 it find the 64 bit bz2 we compiled and stops there.

Comment 5

[(not currently active) Ted Mielczarek]

This can land on the build-system branch:
http://hg.mozilla.org/projects/build-system
http://tbpl.mozilla.org/?tree=Build-System

Comment 6

[(not currently active) Ted Mielczarek]

http://hg.mozilla.org/projects/build-system/rev/693cc4538c40

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/693cc4538c40