Closed Bug 629815 Opened 9 years ago Closed 9 years ago

macosx/universal/mozconfig.common should not select the compiler

Categories

(Firefox Build System :: General, defect)

x86_64
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: espindola, Assigned: espindola)

References

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 file, 2 obsolete files)

Attached patch don't select the compiler (obsolete) — Splinter Review
macosx/universal/mozconfig.common forces the compiler to be gcc 4.2. This looks unnecessary and prevents building with clang.
Attachment #508029 - Attachment is patch: true
Attachment #508029 - Flags: review?(khuey)
Attached patch Use gcc-4.2 if CC is not set (obsolete) — Splinter Review
Assignee: nobody → respindola
Attachment #508029 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #508029 - Flags: review?(khuey)
Attachment #508032 - Flags: review?(ted.mielczarek)
Comment on attachment 508032 [details] [diff] [review]
Use gcc-4.2 if CC is not set

I was going to originally say that the universal build config is very specific to what we support on tinderbox, but as implemented this patch is fine. Given your latest posts I'd be interested in trying Clang on our official builds in the near future.
Attachment #508032 - Flags: review?(ted.mielczarek) → review+
I don't see the point in taking this on trunk, we're not going to ship Firefox 4 with clang. We can take it after we ship.
Attachment #508032 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
Attachment #508032 - Flags: approval2.0+ → approval2.0-
Keywords: checkin-needed
Attached patch updated patchSplinter Review
This patch also move the test for NATIVE_CPU before we change CC and CXX. This is a bug in the current file, but it only causes problem with xcode4's linker.

In 3.2.5 mbsdiff ends up being linked with the system bz2. With 4 it find the 64 bit bz2 we compiled and stops there.
Attachment #508032 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/693cc4538c40
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.