Closed Bug 629815 Opened 9 years ago Closed 9 years ago
.common should not select the compiler
macosx/universal/mozconfig.common forces the compiler to be gcc 4.2. This looks unnecessary and prevents building with clang.
Attachment #508032 - Flags: review?(ted.mielczarek)
Comment on attachment 508032 [details] [diff] [review] Use gcc-4.2 if CC is not set I was going to originally say that the universal build config is very specific to what we support on tinderbox, but as implemented this patch is fine. Given your latest posts I'd be interested in trying Clang on our official builds in the near future.
Attachment #508032 - Flags: review?(ted.mielczarek) → review+
Attachment #508032 - Flags: approval2.0?
I don't see the point in taking this on trunk, we're not going to ship Firefox 4 with clang. We can take it after we ship.
This patch also move the test for NATIVE_CPU before we change CC and CXX. This is a bug in the current file, but it only causes problem with xcode4's linker. In 3.2.5 mbsdiff ends up being linked with the system bz2. With 4 it find the 64 bit bz2 we compiled and stops there.
Attachment #508032 - Attachment is obsolete: true
This can land on the build-system branch: http://hg.mozilla.org/projects/build-system http://tbpl.mozilla.org/?tree=Build-System
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.