629839 - compiler version detection in security/coreconf/Darwin.mk fails for clang

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: drop support for old gcc versions.

The logic for detecting the compiler version greps for "gcc version", and therefore fails with clang.

There are many ways to fix this, the patch I am attaching fixes it by dropping support for really old gcc's (clang's driver behaves like 4.2's). If we must still support 4.0 or 3.x (really?), let me know and I will upload a different patch.

Comment 1

[Wan-Teh Chang]

NSS is used by non-Mozilla products and older versions of
Mozilla products, so it is best to not rip out support for
GCC 4.0 and 3.x.

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

ah, didn't realized this file was part of NSS. Will test and upload a different one in a sec. Thanks

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Use the -dumpversion hack

Using -dumpversion is shorter than what we have now and as a hack clang already prints 4.2.1 when given that flag.

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: now with the correct quotes

Comment 5

[Wan-Teh Chang]

Comment on attachment 508073 [details] [diff] [review]
now with the correct quotes

r=wtc.  I'm glad you found a simple solution.  Why didn't we use
-dumpversion before?  It's documented in the GCC 3.0 manual:
http://gcc.gnu.org/onlinedocs/gcc-3.0.4/gcc_3.html#IDX286

Before I saw this patch, I studied
https://wiki.mozilla.org/Mac:Build_Requirements#Compatibility_Matrix
Although I don't fully understand the compatibility matrix, it seems
that we can drop support for GCC 3.3, but still need to support GCC
4.0, assuming mozilla-1.8.1 and older are no longer supported.

Comment 6

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Hey, thanks for the pointer.
I have no idea why -dumpversion was not used before, the code is a lot older than me (working on Mozilla).

I will probably send an independent patch dropping the 3.3 since that is the really nasty part of the makefile...

Comment 7

[Wan-Teh Chang]

Patch checked in on the NSS trunk (NSS 3.13) and the
NSS_3_12_BRANCH (NSS 3.12.10).

Checking in Darwin.mk;
/cvsroot/mozilla/security/coreconf/Darwin.mk,v  <--  Darwin.mk
new revision: 1.27; previous revision: 1.26
done

Checking in Darwin.mk;
/cvsroot/mozilla/security/coreconf/Darwin.mk,v  <--  Darwin.mk
new revision: 1.24.2.2; previous revision: 1.24.2.1
done