Even though the treeclosure hook doesn't hit nearly as often as tbpl, so it didn't feel the need to make a separate status.html static file like tbpl did, the hook really should take advantage of it - fetching the whole waterfall to get a the word "CLOSED" is rather excessive. Untested, since I don't know how to test it, but I did at least verify that all the URLs work.
Attachment #508071 - Flags: review?(ted.mielczarek)
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Comment on attachment 508071 [details] [diff] [review] Fix v.1 Seems totally reasonable, and we already have tests that cover this (they obviously don't hit the live Tinderbox page, or they wouldn't make very good tests), but you will have to adjust the URLs in the tests to match your changes here: http://hg.mozilla.org/hgcustom/hghooks/file/04b0488534f5/runtests.py#l230 The redirect method there gives a URL and its contents, and causes the test to expect that that URL will be the next one fetched, and return that string as the URL contents: http://hg.mozilla.org/hgcustom/hghooks/file/04b0488534f5/runtests.py#l192 You can run the tests with "python runtests.py". r=me with the tests fixed.
Attachment #508071 - Flags: review?(ted.mielczarek) → review+
Attachment #508155 - Flags: review?(ted.mielczarek) → review?(bugzilla)
Comment on attachment 508155 [details] [diff] [review] [checked in] patch for c-c hook as well. (with test fixed for CC hook) I've pushed this as I'm reviewing another patch that is going to add to the tests, so may as well get this url changed first.
Attachment #508155 - Attachment description: patch for c-c hook as well. (with test fixed for CC hook) → [checked in] patch for c-c hook as well. (with test fixed for CC hook)
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Product: Release Engineering → Developer Services
You need to log in before you can comment on or make changes to this bug.