629893 - Entity "props.policy.label" [ @ cookieAcceptDialog.dtd ] is unused and should be removed

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Hubert Gajewski]

Entity "props.policy.label" is unused - it should be removed

https://mxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/cookie/cookieAcceptDialog.dtd#7

Found in cookieAcceptDialog.dtd file only:
https://mxr.mozilla.org/mozilla-central/search?string=props.policy.label&find=%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

There is no mentioned entity in cookieAcceptDialog.xul:
https://mxr.mozilla.org/mozilla-central/source/toolkit/components/cookie/content/cookieAcceptDialog.xul

Comment 1

[Hubert Gajewski]

Attachment: Patch (trunk)

Comment 2

[Axel Hecht [:Pike]]

This seems to be a fall-out from unreviewed parts landing as part of http://hg.mozilla.org/mozilla-central/rev/b19ea8c3d39c from bug 383993.

This is looong gone, doesn't hurt to carry it around for a few more weeks.

Let's land this post-fx4.

Comment 3

[Hubert Gajewski]

(In reply to Axel Hecht [:Pike] from comment #2)
> Let's land this post-fx4.

It's time.

Comment 4

[Axel Hecht [:Pike]]

Can you create an updated patch following the guidelines on http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed and set the checkin-needed flag here?

Comment 5

[Hubert Gajewski]

Attachment: Patch with title (trunk)

Comment 6

[Hubert Gajewski]

Attachment: Patch with title (trunk)

I forgot about the comment in patch.

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/4b9a2c610a5e

Comment 8

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/4b9a2c610a5e