Enable libnotify support for Mozilla Qt.

RESOLVED INCOMPLETE

Status

Core Graveyard
Widget: Qt
RESOLVED INCOMPLETE
7 years ago
a year ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 508219 [details] [diff] [review]
Enable libnotify for Qt port

Qt port does not build any support of libnotify system.
I think for Qt/Gtk port libnotify should be available and enabled.

This will enable libnotify for maemo5 and desktop Qt builds...
We still need implement notify for KDE (KNotification), and Maemo6.
Attachment #508219 - Flags: review?(doug.turner)
(Assignee)

Comment 1

7 years ago
Created attachment 508224 [details] [diff] [review]
Enable libnotify for Qt port

Add linking with libnotify libraries.
Assignee: nobody → romaxa
Attachment #508219 - Attachment is obsolete: true
Attachment #508224 - Flags: review?(doug.turner)
Attachment #508219 - Flags: review?(doug.turner)
(Assignee)

Comment 2

7 years ago
Can we do it like this, or any other suggestions?
libnotify is not a natural choice for Qt environments as it has its base in Gnome and also using glib/gdk/gtk. 
Also libnotify support ends up in mozgnome component as sytem-alerts-service so does linking libnotify into libxul do anything at all?
The original XUL alerts-service is already in place for Qt, right? So there is something already.
I'm probably missing some detail why and how linking to libnotify is needed or sufficient.

Comment 4

7 years ago
Comment on attachment 508224 [details] [diff] [review]
Enable libnotify for Qt port

ted is a build owner/peer.
Attachment #508224 - Flags: review?(doug.turner) → review?(ted.mielczarek)
(Assignee)

Comment 5

7 years ago
(In reply to comment #3)
> libnotify is not a natural choice for Qt environments as it has its base in
> Gnome and also using glib/gdk/gtk. 

Yes, probably we should make that component using dynamic library load and initialize that only when libnotify component available....

> Also libnotify support ends up in mozgnome component as sytem-alerts-service so
> does linking libnotify into libxul do anything at all?

That make Qt-Firefox working with Gnome-Desktop, (not sure if KDE has some proxy between libnotify<->KNotify...)

> The original XUL alerts-service is already in place for Qt, right? So there is
> something already.

I'm using ION3 window manager, without gnome initialization, and I have libnotify working fine, and good integrated with this window-manager.

XUL-notify alerts are not displaying properly at all. not sure... probably we should double check some Qt::Popup initialization flags when popup xul-windows initialized.

> I'm probably missing some detail why and how linking to libnotify is needed or
> sufficient.
Comment on attachment 508224 [details] [diff] [review]
Enable libnotify for Qt port

>diff --git a/widget/src/qt/Makefile.in b/widget/src/qt/Makefile.in
>--- a/widget/src/qt/Makefile.in
>+++ b/widget/src/qt/Makefile.in
>@@ -88,32 +88,42 @@ EXTRA_DSO_LDOPTS = \
> 		$(MOZ_COMPONENT_LIBS) \
> 		-lgkgfx \
> 		-lthebes \
> 		$(MOZ_JS_LIBS) \
> 		$(MOZ_QT_LIBS) \
> 		$(GLIB_LIBS) \
> 		$(QCMS_LIBS) \
> 		$(XEXT_LIBS) \
>+		$(MOZ_LIBNOTIFY_LIBS) \
> 		$(NULL)
> 
> 
> EXTRA_DSO_LDOPTS += -L$(DIST)/lib $(MOZ_XLIB_LDFLAGS) $(XLIBS)
> 
>+ifdef MOZ_ENABLE_LIBNOTIFY
>+CPPSRCS	+= \
>+		../gtk2/nsImageToPixbuf.cpp \
>+		$(NULL)
>+EXPORTS		+= \
>+		../gtk2/nsIImageToPixbuf.h \
>+		$(NULL)
>+endif

Please use two-space indentation here, not tabs, and leave out the tabs between the variable names and = as well. (I know this conflicts with the rest of the file, that's ok.)

r=me on the patch itself, although I think Wolfgang's comments deserve consideration. If this is a GTK/GLib library, why are we using it on Qt?
Attachment #508224 - Flags: review?(ted.mielczarek) → review+

Comment 7

a year ago
In bug 1282866, I have removed the QT code from the Firefox tree with the approval of the active peer. That code is not currently maintained by any team.

I have looked through the bugs in the Widget: Qt bugzilla component and I believe all of these are no longer relevant because the Qt code has been removed. If you believe that this bug is still valid, please move it to another more appropriate bugzilla component as you reopen it.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → INCOMPLETE
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.