630016 - Addon builder XPI with toolbar buttons code to respond to clicks is broken by default

Status: VERIFIED DUPLICATE of bug 624245

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[mike.maccana]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_6; en-US) AppleWebKit/534.13 (KHTML, like Gecko) Chrome/9.0.597.83 Safari/534.13
Build Identifier: 

Using the extension builder and checking toolbar button results in the following code inside overlay.js. The code does not create any prompts, apparently as 'this' cannot be used in onLoad. The code has not been modified in any way from the XPI produced by Addon Builder.

	var mytestextension = {
	  onLoad: function() {
	    // initialization code
	    this.initialized = true;
	    this.strings = document.getElementById("mytestextension-strings");
	  },

	  onMenuItemCommand: function(e) {
	    var promptService = Components.classes["@mozilla.org/embedcomp/prompt-service;1"]
	                                  .getService(Components.interfaces.nsIPromptService);
	    promptService.alert(window, this.strings.getString("helloMessageTitle"),
	                                this.strings.getString("helloMessage"));
	  },

	  onToolbarButtonCommand: function(e) {
	    // just reuse the function above.  you can change this, obviously!
	    mytestextension.onMenuItemCommand(e);
	  }
	};



Reproducible: Always

Steps to Reproduce:
1.Create extension with 'Toolbar button'.
2.Load extension
3.Click toolbar button
Actual Results:  
No response to clicking.

Expected Results:  
A hello message should be presented.

Further details and discussion are at http://stackoverflow.com/questions/4831459/firefox-addon-promptservice-doesnt-work-from-mozillas-own-sample-code

Comment 1

[Dietrich Ayala (:dietrich)]

Will, any idea what this person is talking about? This code is clearly not Add-on SDK code.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'd guess he's talking about this: https://addons.mozilla.org/en-US/developers/tools/builder

Comment 3

[Dietrich Ayala (:dietrich)]

I've never seen that! I thought this was related to the Add-on Builder (https://builder.addons.mozilla.org/).

Apparently AMO has two products with the same name.

Comment 4

[mike.maccana]

To confirm, the product mentioned is indeed the one that appears at 
https://addons.mozilla.org/en-US/developers/tools/builder per Wes' comment.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I believe this is the same issue as bug 624245 ('this' not referencing the correct thing in within onload.

Comment 6

[Shawn Wilsher :sdwilsh]

Ah, yup!