Closed
Bug 630027
Opened 13 years ago
Closed 13 years ago
replace mozRequestAnimationFrame() with mozRequestAnimationFrame(callback) in AnimatedZoom.js
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mfinkle, Assigned: mfinkle)
Details
(Keywords: perf)
Attachments
(1 file)
|
2.24 KB,
patch
|
stechz
:
review+
|
Details | Diff | Splinter Review |
Bug 621984 already did this in input.js Rationale is that using a callback could yield better performance.
Attachment #508245 -
Flags: review?(ben)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 508245 [details] [diff] [review] patch No idea if this helps perf, but it's cleaner.
Attachment #508245 -
Flags: review?(ben) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
pushed: http://hg.mozilla.org/mobile-browser/rev/b9bc51d30b32
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 3•13 years ago
|
||
Can somebody please verify this bug?
|
||
Comment 4•13 years ago
|
||
This was supposedly helping performance, I remember I tried to look at some performance graphs, but I couldn't really notice any difference in performance.
|
|
Assignee | |
Comment 5•13 years ago
|
||
Even if we don't see a performance improvement, this was decided to be the better way to handle animation frames. Since everything still works, I'll verify it.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•