replace mozRequestAnimationFrame() with mozRequestAnimationFrame(callback) in AnimatedZoom.js

VERIFIED FIXED

Status

defect
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

({perf})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch patchSplinter Review
Bug 621984 already did this in input.js

Rationale is that using a callback could yield better performance.
Attachment #508245 - Flags: review?(ben)
Keywords: perf
Comment on attachment 508245 [details] [diff] [review]
patch

No idea if this helps perf, but it's cleaner.
Attachment #508245 - Flags: review?(ben) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/b9bc51d30b32
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

Comment 3

8 years ago
Can somebody please verify this bug?
This was supposedly helping performance, I remember I tried to look at some performance graphs, but I couldn't really notice any difference in performance.
Even if we don't see a performance improvement, this was decided to be the better way to handle animation frames. Since everything still works, I'll verify it.
Status: RESOLVED → VERIFIED
bugspam
Assignee: nobody → mark.finkle
You need to log in before you can comment on or make changes to this bug.