Closed Bug 630062 Opened 12 years ago Closed 12 years ago

Don't throw on setting lineWidth and ignore non-positive values

Categories

(Core :: Graphics: Canvas2D, defect)

Product:
Core
Component:
Graphics: Canvas2D
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b11

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

(Keywords: dev-doc-complete, html5)

Attachments

(1 file, 1 obsolete file)

Patch for checkin
2.19 KB, patch
Details | Diff | Splinter Review
Attached patch Patch v1 (obsolete) — — Splinter Review 
This patch makes us pass

http://www.w3c-test.org/html/tests/approved/canvas/2d.line.width.invalid.html
Attachment #508279 - Flags: review?(roc)
Flags: in-testsuite+
Hmm, why lineWidth doesn't throw but arc should throw (Bug 630068).
Sounds like an inconsistency in the API, which should be fixed in the spec.
But perhaps there is some reason for this behavior.
It seems like attributes don't throw, and methods do. That seems reasonable.
Ok, that makes at least some sense.
Assignee: nobody → Ms2ger
Thanks!
Attachment #508279 - Attachment is obsolete: true
Keywords: checkin-needed
Whiteboard: [needs review]
http://hg.mozilla.org/mozilla-central/rev/22aa43f18646
Status: NEW → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b11
Added note to:

https://developer.mozilla.org/en/DOM/CanvasRenderingContext2D#Notes

And listed the change on Firefox 4 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.