Closed Bug 630083 Opened 13 years ago Closed 13 years ago

Use SetParsedAttr in nsSVGElement::DidChangeXxx instead of SetAttr

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

(Keywords: perf)

Attachments

(1 file)

We should use SetParsedAttr in nsSVGElement::DidChangeXxx instead of SetAttr to avoid a serialize-reparse cycle.
Attached patch patchSplinter Review
This depends on bug 610990. Essentially it just changes the serialize-parse loop to just the serialize. Should be very safe.
Assignee: nobody → jwatt
Status: NEW → ASSIGNED
Attachment #508303 - Flags: review?(roc)
Attachment #508303 - Flags: approval2.0?
Attachment #508303 - Flags: review?(roc)
Attachment #508303 - Flags: review+
Attachment #508303 - Flags: approval2.0?
Attachment #508303 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/7aa71efbb69c
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: