630092 - Missing notification for allowing offline app cache

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Robert Kaiser]

When loading http://html5demos.com/offlineapp in Firefox, I get a notification where I can allow offline app caching, but I don't get that in SeaMonkey.

It just sets a permission for "offline-apps" in the end, and if that one is set, the demo works, but the notification is missing in SeaMonkey.

Comment 1

[Philip Chee]

Possibly relevant Firefox bugs:
  [Bug 394392] UI for enabling/disabling offline applications.
  [bug 414931] remove cruft from browser.js and make offline storage website list in preferences.
  [Bug 399528] Add 'never for this site' option to the offline-app notification bar.
  [Bug 419108] Offline exceptions button uses Ci where it isn't available.
  [Bug 397417] monitor disk usage of offline apps in the UI.
  [Bug 424017] list of offline apps broken on non-mac platforms.
  [Bug 424281] Fix up openAdvancedPreferences() for modal prefs dialogs.
  [Bug 442806] Use separate, versioned caches for offline apps.
  [Bug 442810] update ui for app cache changes.
  [Bug 526230] nsIApplicationCacheService::getGroups count outparam should be optional.

Comment 2

[Robert Kaiser]

Bug 394392 (the main/notification part of it, the prefs part is something I'm integrating into Data Manager, that's how I found this) sounds like it, though we should check to see that we port the current version of this.

That should be relatively easy to do, maybe Edmund wants to help there?

Comment 3

[[e-mail]]

(In reply to comment #1)
> Possibly relevant Firefox bugs:
>   [Bug 394392] UI for enabling/disabling offline applications.
Not forgetting the dependent bug 462856.

Comment 4

[[e-mail]]

Rather conveniently, indexedDB uses the same strings, so they're already there!

Comment 5

[[e-mail]]

Attachment: WIP

This just does the prompt; there's another part that monitors usage.

Comment 6

[[e-mail]]

Attachment: Notifications part only [Checked in: Comment 10]

Apparently the quota warning is expected to be able to open the offline app preferences, but somebody has to write them first, so in the mean time it's just a plain notification bar.

Comment 7

[Ian Neal]

Comment on attachment 510167 [details] [diff] [review]
Notifications part only
[Checked in: Comment 10]

Is there a bug logged on the offline app preferences you mentioned and for linking in this notification, if so could you add the relevant dependencies, if not could you add the bugs with relevant dependencies.
Would this ever become a doorhanger?

Comment 8

[[e-mail]]

(In reply to comment #7)
> Is there a bug logged on the offline app preferences you mentioned and for
> linking in this notification, if so could you add the relevant dependencies, if
> not could you add the bugs with relevant dependencies.
Well, I'm not sure what prefs there are, but from comment #2 it sounds as if KaiRo was last looking into that side of it.

> Would this ever become a doorhanger?
Possibly (by overriding offlineAppRequested and checkUsage and maybe some refactoring), but I would have to wait for Firefox to convert theirs first.

Comment 9

[Robert Kaiser]

(In reply to comment #8)
> Well, I'm not sure what prefs there are, but from comment #2 it sounds as if
> KaiRo was last looking into that side of it.

I haven't really looked into much of this, actually, in that comment I just went through the bugs and looked what sounds like it, which a fast glance at its patch.
Also, I don't know much about prefs for this, I just stumbled over the whole issue when investigating the web storage panel for Data Manager.

Comment 10

[[e-mail]]

Comment on attachment 510167 [details] [diff] [review]
Notifications part only
[Checked in: Comment 10]

Pushed changeset 3c6ddf017567 to comm-central.

What other parts are there to finish support for offline apps?

Comment 11

[Justin Wood (:Callek)]

No comments to neil's Q since Feb, initial patch landed; this looks done.

Comment 12

[[e-mail]]

Looks like we're still missing the preferences.