Closed Bug 630176 Opened 10 years ago Closed 10 years ago

Add the comm-central source stamp to Thunderbird's source stamp file

Categories

(Thunderbird :: Build Config, defect)

defect
Not set
normal

Tracking

(thunderbird3.1 .10-fixed)

RESOLVED FIXED
Thunderbird 3.3a3
Tracking Status
thunderbird3.1 --- .10-fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
Now that bug 549958 has altered how the source stamp files are done, we should append the comm-central stamp to Thunderbird's version of the file.

Patch attached to do that (I would copy and paste to suite, but I expect that SM probably wants to do their extension repos as well).
Attachment #508382 - Flags: review?(bugspam.Callek)
Comment on attachment 508382 [details] [diff] [review]
The fix

I'm happy with this as a standalone, but I *really* want this taken one step further for us... and basically reverse http://hg.mozilla.org/comm-central/rev/ce2bbf8d11fd

By doing s/MOZ_SOURCE_STAMP/COMM_SOURCE_STAMP/ in c-c (even with an export from our root Makefile) and even having it utilized for suite, etc. (for the sourcestamp file) suite can add the extensions to the sourcestamp file in another bug.

But if that is more than you have time for, or disagree with my plan you can land this as is, just please file a bug for the plan I outlined.
Attachment #508382 - Flags: review?(bugspam.Callek)
Attachment #508382 - Flags: review+
Attachment #508382 - Flags: feedback-
Checked in: http://hg.mozilla.org/comm-central/rev/bbfc217dd3ff

Raised bug 630487 on the follow-up tidy up.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a3
Blocks: 630487
Flags: in-testsuite-
Comment on attachment 508382 [details] [diff] [review]
The fix

Should consider for 3.1.9 once the dependent bug lands.
Attachment #508382 - Flags: approval-thunderbird3.1.9?
Attachment #508382 - Flags: approval-thunderbird3.1.10? → approval-thunderbird3.1.10+
You need to log in before you can comment on or make changes to this bug.