Closed Bug 630210 Opened 9 years ago Closed 5 years ago

Seemingly random alignment of the close button in popup notifications

Categories

(Toolkit :: Themes, defect, P4)

defect
Points:
2

Tracking

()

RESOLVED FIXED
mozilla40
Iteration:
40.3 - 11 May
Tracking Status
firefox40 --- fixed
blocking2.0 --- -

People

(Reporter: dao, Assigned: dao)

References

Details

(Whiteboard: [doorhanger][fxsearch][searchhijacking])

Attachments

(2 files, 1 obsolete file)

Attached image screenshot
No description provided.
blocking2.0: --- → ?
Not nice but I don't think it is terrible enough to block.
blocking2.0: ? → -
Blocks: 577927
Whiteboard: [doorhanger]
Assignee: nobody → dao
OS: Linux → All
Hardware: x86 → All
Depends on: 1157148
Attached patch patch (obsolete) — Splinter Review
Status: NEW → ASSIGNED
Iteration: --- → 40.2 - 27 Apr
Points: --- → 2
Flags: qe-verify-
Flags: firefox-backlog+
Whiteboard: [doorhanger] → [doorhanger][fxsearch][searchhijacking]
Priority: -- → P4
Iteration: 40.2 - 27 Apr → 40.3 - 11 May
Attached patch patchSplinter Review
updated to not depend on bug 1157148 since there's some ui-review lag
Attachment #8597229 - Attachment is obsolete: true
Attachment #8599341 - Flags: review?(dtownsend)
No longer depends on: 1157148
Attachment #8599341 - Flags: review?(dtownsend) → review+
https://hg.mozilla.org/mozilla-central/rev/bad247df4aec
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #5)
> https://hg.mozilla.org/mozilla-central/rev/bad247df4aec

Does this have tests to make sure the button is showing up where we expect?
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #6)
> (In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #5)
> > https://hg.mozilla.org/mozilla-central/rev/bad247df4aec
> 
> Does this have tests to make sure the button is showing up where we expect?

No, tests aren't practical for these kind of random layout details.
(In reply to Dão Gottwald [:dao] from comment #7)
> tests aren't practical for these kind of random layout details.

Okay, thanks Dão.
Flags: in-testsuite-
Depends on: 1167716
You need to log in before you can comment on or make changes to this bug.