630218 - Reflect.parse("x.*") shouldn't mark the MemberExpression as computed

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

Reflect.parse("x.*") is the same as Reflect.parse("x[*]").
This is a bug because they're two different programs.

  js> x = <x/>;
  <x/>
  js> x.*
                                     <-- empty XMLList
  js> x[*]
  typein:10: ReferenceError: reference to undefined XML name *::*

Both ASTs contain a node with {type: "MemberExpression", computed: true}.
The first one should have computed: false.

Something similar goes for @x and @[x].

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

This adds a .computed property to XMLAttributeSelector nodes.

(I ran across this bug while trying to test some Reflect.stringify code; see bug 590755.)

Comment 2

[Dave Herman [:dherman]]

Comment on attachment 508425 [details] [diff] [review]
v1

Good catch, thanks. r=me

Dave

Comment 3

[Jason Orendorff [:jorendorff]]

http://hg.mozilla.org/tracemonkey/rev/923b87e79ef9

Comment 4

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/923b87e79ef9