Closed
Bug 630362
Opened 13 years ago
Closed 13 years ago
remove jsbridge CLI
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: harth, Assigned: harth)
Details
Attachments
(1 file)
|
7.50 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
jsbridge shouldn't have a CLI. Looking at the code it seems the CLI exists to provide a REPL. I don't think anyone uses it for this and in any case there is some hard-coded browser window logic in the jsbridge API, so it's not exactly a clean cut module that other non-Mozilla Python modules would use.
|
Assignee | |
Comment 1•13 years ago
|
||
This patch takes out jsbridge's CLI and add the --debug and --port arguments to mozmill's CLI.
Assignee: nobody → fayearthur+bugs
Attachment #508922 -
Flags: review?(jhammel)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 508922 [details] [diff] [review] remove jsbridge cli It doesn't look like get_profile is used at all; other than that looks good. Maybe just delete the get_profile function altogether?
Attachment #508922 -
Flags: review?(jhammel) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
removed the get_profile master: https://github.com/mozautomation/mozmill/commit/b3d591e6f486311bda287819a87ea12d1316c6f6
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•