Status

RESOLVED FIXED
8 years ago
2 years ago

People

(Reporter: harth, Assigned: harth)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
jsbridge shouldn't have a CLI. Looking at the code it seems the CLI exists to provide a REPL. I don't think anyone uses it for this and in any case there is some hard-coded browser window logic in the jsbridge API, so it's not exactly a clean cut module that other non-Mozilla Python modules would use.
(Assignee)

Comment 1

8 years ago
Created attachment 508922 [details] [diff] [review]
remove jsbridge cli

This patch takes out jsbridge's CLI and add the --debug and --port arguments to mozmill's CLI.
Assignee: nobody → fayearthur+bugs
Attachment #508922 - Flags: review?(jhammel)

Comment 2

8 years ago
Comment on attachment 508922 [details] [diff] [review]
remove jsbridge cli

It doesn't look like get_profile is used at all; other than that looks good. Maybe just delete the get_profile function altogether?
Attachment #508922 - Flags: review?(jhammel) → review+
(Assignee)

Comment 3

8 years ago
removed the get_profile

master:
https://github.com/mozautomation/mozmill/commit/b3d591e6f486311bda287819a87ea12d1316c6f6
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.