"Launch Application" dialog when using youtube (android/mobile version)

VERIFIED FIXED

Status

VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

Trunk
All
Android
Bug Flags:
in-litmus +

Details

Attachments

(3 attachments)

(Assignee)

Description

8 years ago
When I click on a video, i get a ugly dialog that tells me that I need to launch an application to play the video.

I think we should just special case this url (vnd.youtube intent).
tracking-fennec: --- → ?
OS: Linux → Android
Priority: -- → P1
Hardware: x86_64 → ARM
Summary: "Launch Application" dialog when using youtube (android/mobile version) → Launch helper app dialog when using youtube (android/mobile version)
(Assignee)

Comment 1

8 years ago
Created attachment 510358 [details] [diff] [review]
m-c changes
Attachment #510358 - Flags: review?(blassey.bugs)
(Assignee)

Comment 2

8 years ago
Created attachment 510360 [details] [diff] [review]
m-b change
Attachment #510360 - Flags: review?(blassey.bugs)
Comment on attachment 510360 [details] [diff] [review]
m-b change

I thought you said this didn't work?
(Assignee)

Comment 4

8 years ago
w/ the m-c change it does
(Assignee)

Updated

8 years ago
Summary: Launch helper app dialog when using youtube (android/mobile version) → "Launch Application" dialog when using youtube (android/mobile version)
(Assignee)

Updated

8 years ago
tracking-fennec: ? → 2.0b5+
Priority: P1 → --
Hardware: ARM → All
(Assignee)

Comment 5

8 years ago
the basic problem is that the type of the nsMIMEInfoAndroid is always null (because it is created with an empty string).  This m-c allows type to return something sane for different mime types.

Right now all the pref "network.protocol-handler.warn-external.*" and related mime-type based preferences do not work on android.

So, tel: and mailto:, which should not prompt the user because we set the preferences here:

http://mxr.mozilla.org/mobile-browser/source/app/mobile.js#108

dose not work -- and we prompt the user.  I'm not sure if this ever worked.  I tried b1, b2, b3, and b4.  None did the right thing.


The windows implementation also does something similar -- basically if there isn't a mimetype, then it uses a scheme.
Comment on attachment 510358 [details] [diff] [review]
m-c changes

https://mxr.mozilla.org/mozilla-central/source/uriloader/exthandler/nsExternalHelperAppService.cpp#1173

the external helper app service assumes that the type of a protocol handler is its scheme.

one nit, please rename mMimeType to mType, since its not always a mime type
Attachment #510358 - Flags: review?(blassey.bugs) → review+
Attachment #510360 - Flags: review?(blassey.bugs) → review+

Comment 8

8 years ago
http://hg.mozilla.org/mozilla-central/rev/128423281c99
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Comment 9

8 years ago
Created attachment 511168 [details] [diff] [review]
followup to preserve mime
Attachment #511168 - Flags: review?(blassey.bugs)
Attachment #511168 - Flags: review?(blassey.bugs) → review+
verified FIXED On build:

Mozilla/5.0 (Android; Linux armv71; rv:2.0b12pre) Gecko/20110210 Firefox/4.0b12pre Fennec/4.0b5pre
Status: RESOLVED → VERIFIED
Flags: in-litmus?
litmus test case created : 15223
Flags: in-litmus? → in-litmus+
You need to log in before you can comment on or make changes to this bug.