630432 - Read GetURL's whitelist of supported protocols from the plist

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: OS Integration, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

To fix bug 629850, I added a whitelist of supported protocols to GetURLCommand.  In his review, Chris Peterson suggested reading those protocols from the plist (where we already announce to the world what protocols we claim to handle).  Stuart agreed, particularly so we don't get out-of-sync between the two as we add and remove protocol support going forward, though he noted it could be a low-priority follow-up.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

There's an unfortunate wrinkle to this, which is described in bug 629850 comment 19. :(

Comment 2

[Stuart Morgan]

We could do plist-plus-additional-entries, so we'd read everything from the plist, then append about: in code.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #2)
> We could do plist-plus-additional-entries, so we'd read everything from the
> plist, then append about: in code.

We eventually allowed about:, data:, and view-source: as allowed protocols in bug 629850 (data: for parity with Safari, about: and view-source: mainly for toolbar scripts).