Closed Bug 630444 Opened 9 years ago Closed 9 years ago

Trim LSP annotations

Categories

(Core :: Networking, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jrmuizel, Assigned: khuey)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Trim lsp annotation (obsolete) — Splinter Review
The LSP annotation code is taking up a large chunk of the AppNotes space, which I'd like to use for other purposes. This should trim it down a bit.
Attachment #508657 - Flags: review?(khuey)
Attachment #508657 - Attachment is patch: true
Attachment #508657 - Attachment mime type: application/octet-stream → text/plain
How about we just remove it from the appnotes entirely?  It gets cut off before anything interesting anyways :-/
(In reply to comment #1)
> How about we just remove it from the appnotes entirely?  It gets cut off before
> anything interesting anyways :-/

That works for me too. Do you want to take it out then?
Sure.
Assignee: nobody → khuey
Attachment #508657 - Attachment is obsolete: true
Attachment #508657 - Flags: review?(khuey)
Attached patch PatchSplinter Review
Ted, want to rubberstamp this?
Attachment #508669 - Flags: review?(ted.mielczarek)
Well, it _is_ a very easy way to notice that a non-English version of Windows is being used.
If that information is particularly useful we could expose it in a much less voluminous manner.
Attachment #508669 - Flags: review?(ted.mielczarek) → review+
Attachment #508669 - Flags: approval2.0+
Why not remove the note variable as well?
OS: Mac OS X → All
Yeah, I'll kill that when I land this.
I landed the reviewed version:
http://hg.mozilla.org/mozilla-central/rev/c698ef73edae

You can fix the dead code in a follow up.
Whiteboard: [approved-patches-landed]
http://hg.mozilla.org/mozilla-central/rev/347c9f93d23b

And the dead code is gone.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [approved-patches-landed]
You need to log in before you can comment on or make changes to this bug.