Status

()

Core
Networking
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jrmuizel, Assigned: khuey)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 508657 [details] [diff] [review]
Trim lsp annotation

The LSP annotation code is taking up a large chunk of the AppNotes space, which I'd like to use for other purposes. This should trim it down a bit.
(Reporter)

Updated

6 years ago
Attachment #508657 - Flags: review?(khuey)
(Reporter)

Updated

6 years ago
Attachment #508657 - Attachment is patch: true
Attachment #508657 - Attachment mime type: application/octet-stream → text/plain
How about we just remove it from the appnotes entirely?  It gets cut off before anything interesting anyways :-/
(Reporter)

Comment 2

6 years ago
(In reply to comment #1)
> How about we just remove it from the appnotes entirely?  It gets cut off before
> anything interesting anyways :-/

That works for me too. Do you want to take it out then?
Sure.
Assignee: nobody → khuey
Attachment #508657 - Attachment is obsolete: true
Attachment #508657 - Flags: review?(khuey)
Created attachment 508669 [details] [diff] [review]
Patch

Ted, want to rubberstamp this?
Attachment #508669 - Flags: review?(ted.mielczarek)

Comment 5

6 years ago
Well, it _is_ a very easy way to notice that a non-English version of Windows is being used.
If that information is particularly useful we could expose it in a much less voluminous manner.
Attachment #508669 - Flags: review?(ted.mielczarek) → review+
Blocks: 626994
Attachment #508669 - Flags: approval2.0+
Why not remove the note variable as well?
OS: Mac OS X → All
Yeah, I'll kill that when I land this.
(Reporter)

Comment 9

6 years ago
I landed the reviewed version:
http://hg.mozilla.org/mozilla-central/rev/c698ef73edae

You can fix the dead code in a follow up.
Whiteboard: [approved-patches-landed]
http://hg.mozilla.org/mozilla-central/rev/347c9f93d23b

And the dead code is gone.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [approved-patches-landed]
You need to log in before you can comment on or make changes to this bug.