Open Bug 630463 Opened 11 years ago Updated 3 years ago

Add --with-directx-sdk=DIR for ANGLE

Categories

(Firefox Build System :: General, defect)

x86
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

People

(Reporter: jag+mozilla, Unassigned)

Details

Attachments

(1 file)

See bug 630019 comment 33.

Ideally we can just use DXSDK_DIR when it's there, and otherwise require the path to be specified via --with-directx-sdk.
I agree with adding a --with-directx-sdk;

I also agree with using DXSDK_DIR *if* it actually works i.e. we should do the check for d3dx9.h and dxguid.lib to validate it;

but I really think that if both fail we need to keep the current approach using the registry, because in some cases it's the only way to have auto-detection working (like on the build slaves).

I am not too concerned about people having multiple SDK versions: that's a rare case, and even so, we're not very picky about the SDK version (any version >= February 2010 should work equally well). I'm much more concerned about auto-detection working without effort for most people.

I make run a tryserver build to explore why the DXSDK_DIR approach failed on tinderboxes.
Yeah, we should absolutely make sure that DXSDK_DIR is set correctly.

The tinderboxes probably don't have that env var set. I guess I don't mind asking people to make sure DXSDK_DIR is set, especially since the installer should've done that. There's a good chance the tinderboxen are the exception, not the rule.
If we need the directory set on the tinderboxes, we should just get it set in the buildbot environment. If we're going to do registry scraping, we should do that in MozillaBuild where we do the rest of the registry scraping. We shouldn't have to do that in configure.
To be clear, in any case I would like us to keep the registry test, if only as a fall-back if nothing else works. I believe a lot in the importance of making it easy to build firefox, and automatic platform detection is a big part of that.

Given that, and given that the registry way is currently working on tinderboxes, I don't really see the point of changing environment variables on tinderboxes.

But yes it's still a good idea to allow people to specify explicitly a patch with --with-directx-sdk and with DXSDK_DIR.
See also: Bug 643732
Currently is not possible to use a separate directory providing a standalone DirectX SDK.

With this patch it's possible to overwrite the path via.  MOZ_DIRECTX_SDK_PATH_OVERWRITE

This way I can use the chromium simplified windows toolchain (MSVC10/Platform SDK/DirectX).

MOZ_DIRECTX_SDK_PATH_OVERWRITE is less likely to clash with an already defined environment variable (like DX_SDK) and will overwrite the registry decision in configure.in It doesn't change the overall logic, and currently simply set a fixed version, anyone know how to read the version from the directx sdk directly?
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.