630477 - Cannot update add-ons if the target filename contains multibyte characters (the update link in VersionCheck.php is invalid)

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: API, defect)

Description

[Kohei Yoshino [:kohei]]

The author of the Kami-Copi add-on reported us that it couldn't be updated to the latest version (1.4) via Add-on Manager. The error was "Invalid file hash (possible download corruption) -261". 

Installation from the listing page seems no problem.

https://addons.mozilla.org/en-US/firefox/addon/6216/

Here's the Version Check URL:

https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id={1D718B47-1056-4ca0-83F5-5BEB3256D7B2}&version=1.3&maxAppVersion=3.6.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=3.6.13&appOS=WINNT&appABI=x86-msvc&locale=ja&currentAppVersion=3.6.13&updateType=97

This update link is invalid.

http://releases.mozilla.org/pub/mozilla.org/addons/6216/?copi_add_on-1.4-fx-windows.xpi

The actual filename is

http://releases.mozilla.org/pub/mozilla.org/addons/6216/%E7%B4%99copi_add_on-1.4-fx-windows.xpi

The Version Check API should not replace a multibyte character with a question mark.

Comment 1

[Wil Clouser [:clouserw]]

Jeff: is this because the add-on was uploaded in the time when we allowed utf-8 in filenames?  In other words, this is no longer happening to newly uploaded files, right?

Comment 2

[Jeff Balogh (:jbalogh)]

(In reply to comment #1)
> Jeff: is this because the add-on was uploaded in the time when we allowed utf-8
> in filenames?  In other words, this is no longer happening to newly uploaded
> files, right?

Correct. I uploaded the file to preview and the name is https://addons.allizom.org/z/mobile/downloads/file/108899/copi_add_on-1.4-fx.xpi?src=devhub.

Comment 3

[Kohei Yoshino [:kohei]]

This add-on also contains multibyte characters (Chinese) in the filename and the update is broken.

https://addons.mozilla.org/ja/firefox/addon/yemark/
http://releases.mozilla.org/pub/mozilla.org/addons/257017/
https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id={F0A16FC7-EAF4-4df0-BDB1-74A80F0C2149}&version=1.3&maxAppVersion=3.6.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=3.6.13&appOS=WINNT&appABI=x86-msvc&locale=ja&currentAppVersion=3.6.13&updateType=97

Comment 4

[Kohei Yoshino [:kohei]]

As an interim measure, I have asked the author of the Kami-Copi add-on to upload a new version with ascii-only filename. It should work well.

Comment 5

[Wil Clouser [:clouserw]]

(In reply to comment #4)
> As an interim measure, I have asked the author of the Kami-Copi add-on to
> upload a new version with ascii-only filename. It should work well.

Thanks.  Any new uploads should work fine (We clean filenames now).  It's just any files uploaded within the month or so this was live will be broken.

Comment 6

[Wil Clouser [:clouserw]]

I see you've renamed the file to fix this problem.  We've rewritten the versioncheck script since then - can you still reproduce this?

Comment 7

[Wil Clouser [:clouserw]]

Thanks for filing this.  Due to resource constraints we are closing bugs which we won't realistically be able to fix.  If you have a patch that applies to this bug please reopen.

For more info see http://micropipes.com/blog/2014/09/24/the-great-add-on-bug-triage/