630487 - Consider consolidating *_SOURCE_STAMP/*_SOURCE_REPO in comm-central

Status: RESOLVED WORKSFORME

(MailNews Core :: Build Config, defect)

Description

[Mark Banner (:standard8)]

We have a few different ways of doing source stamps/repos at the moment, and we should consider consolidating those into one file, probably Makefile.in, so that they can be used everywhere.

(xref bug 630176 comment 1).

Comment 1

[Ruediger Lahl]

(In reply to comment #0)

> We have a few different ways of doing source stamps/repos at the moment, and we
> should consider consolidating those into one file, probably Makefile.in, so
> that they can be used everywhere.

Is that the reason why all SM-files currently dated to 01.01.2010?

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> (In reply to comment #0)
> 
> > We have a few different ways of doing source stamps/repos at the moment, and we
> > should consider consolidating those into one file, probably Makefile.in, so
> > that they can be used everywhere.
> 
> Is that the reason why all SM-files currently dated to 01.01.2010?

No, that's a different bug to do with build ids (and I don't know what/where it is).

Comment 3

[Serge Gautherie (:sgautherie)]

Current situation is:

TB (after bug 630176, I assume):
{
20110211065630
http://hg.mozilla.org/mozilla-central/rev/57157294fb52
http://hg.mozilla.org/comm-central/rev/625f6f4e11bd
}

SM:
{
20110211043452
http://hg.mozilla.org/mozilla-central/rev/584a654b4be6
}

Comment 4

[Justin Wood (:Callek)]

(In reply to comment #3)
> Current situation is:
I think you referenced the wrong csets

Comment 5

[Justin Wood (:Callek)]

err actually I see what you did there... nevermind :/

Comment 6

[Serge Gautherie (:sgautherie)]

We now have the same APP_SOURCE_* code in
/mail/installer/Makefile.in
and
/suite/installer/Makefile.in

Is this bug simply about merging them into /Makefile.in?

Comment 7

[Mark Banner (:standard8)]

I think over time, everything has been simplified enough that this is fine now.