63053 - Window state is lost after minimizing

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Blake Ross]

Build ID: 12/16 trunk (tip)

Steps to Reproduce:

(1) Open an instance of Navigator.
(2) Maximize it (using the maximize button in the top right of the titlebar).
(3) Minimize it (using the minimize button in the top right of the titelbar).
(4) Maximize it (click on its placeholder in the taskbar).

Result: the window maximizes then quickly restores. see bug 32148.

Comment 1

[Péter Bajusz]

Hmmm. This is caused by the combination of two problems:

1. NS_SIZEMODE event is spawsned in WM_SYSCOMMAND.
   This is already bad see my comments in bug 63052
   When restoring a minimized window we get "SC_RESTORE" from which the code
   badly assumes we just entered the "Normal" state...

2. The handler of the NS_SIZEMODE handler in
   "xpfe/appshell/src/nsWebShellWindow.cpp" is calling SetSizeMode which
   sets the the window state by calling ShowWindow.
   This is bad(tm). An event handler that is notified about a mode change,
   shouldn't change the mode itself. It has the potential to create an endless
   flow of events.

Comment 2

[Target]

Confirmed in 2000121608 under win98 SE

Comment 3

[Blake Ross]

Marking fixed per Péter's 12/18 comment in bug 63052 that his patch fixes this 
also.