630536 - Remove %(locale)s

Status: RESOLVED FIXED

(support.mozilla.org :: Localization, task, P3)

Description

[Scoobidiver (away)]

Remove %(locale)s to display the language to prevent gender/declension/uppercase errors.
See https://bugzilla.mozilla.org/show_bug.cgi?id=625893#c2 for a possible solution.

Comment 1

[Paul Craciunoiu [:paulc]]

More details on this please? The string in bug 625893 comment 2 has been fixed.

Comment 2

[James Socol [:jsocol, :james]]

(In reply to comment #1)
> More details on this please? The string in bug 625893 comment 2 has been fixed.

git grep -n '%(locale)s'

Remove instances and stop formatting the locale in where those strings are used. Add L10n comments specifying whether we mean "English" or "current locale." Break into multiple strings and use context if necesary.

Comment 3

[Scoobidiver (away)]

Following the https://support.mozilla.com/en-US/forums/contributors/705028 thread that shows that L10n comments are not read because of automatic translation tools, the locale must be removed from Verbatim and not replaced by English with L10n comments.

So the solution for two remaining occurrences is:
* "Our volunteers haven't translated this article into %(locale)s yet" becomes "Our volunteers haven't translated this article yet"
* "A revision must be based on a revision of the %(locale)s document." becomes "A revision must be based on a revision of the current document." or something better as I don't know the context.

Comment 4

[James Socol [:jsocol, :james]]

(In reply to comment #3)
> So the solution for two remaining occurrences is:
> * "Our volunteers haven't translated this article into %(locale)s yet" becomes
> "Our volunteers haven't translated this article yet"

This works for me. Kadir/Michael?

> * "A revision must be based on a revision of the %(locale)s document." becomes
> "A revision must be based on a revision of the current document." or something
> better as I don't know the context.

This must mention English (here %(locale)s gets replaced with "English") as that's what it means. "A revision must be based on a revision of the English document."

Comment 5

[David Tenser [:djst]]

(In reply to comment #4)
> (In reply to comment #3)
> > So the solution for two remaining occurrences is:
> > * "Our volunteers haven't translated this article into %(locale)s yet" becomes
> > "Our volunteers haven't translated this article yet"
> 
> This works for me. Kadir/Michael?

That works for me too, but (Michael), have we thought about "No one has translated this article yet"? I know we discussed before about the use of "volunteers" and we agreed that it was fine to use it, but it still sounds very specific to me, especially when I'm trying to imagine what the Swedish translation would be for it. 

"No one" seems more neutral to me than "our volunteers". Thought it might be worth bringing up since we're about to change a string here. Fwiw, I'm fine with keeping it the way Scoobidiver proposes, too.

Comment 6

[Verdi [:verdi] Best to slack me]

After talking to David I think the strings should be:

First one:
"No one has helped translate this article yet."

Second one:
"A revision must be based on the English document."

Comment 7

[Verdi [:verdi] Best to slack me]

I'm a little fuzzy on where this is shown to people but maybe that second string should say, "A translation must be based on the English article." since we usually use translation for what a localizer does and we use article instead of document. Kadir, does this sound right?

Comment 8

[Kadir Topal [:atopal]]

I'm with Michael here for 1 and 2. As far as I can tell (2) comes up when you try to translate an article that is original, but not in English.

Comment 9

[James Socol [:jsocol, :james]]

(In reply to comment #8)
> I'm with Michael here for 1 and 2. As far as I can tell (2) comes up when you
> try to translate an article that is original, but not in English.

It should be difficult now to actually see this message unless you're doing something nefarious.

The message comes up when you have a revision "based on" (in our internal definition of "based on") an unacceptable revision, like a revision of a translated document. Since we now allow localizations "based on" unapproved or rejected revisions, this is really hard to trigger.

Comment 10

[David Tenser [:djst]]

Good to know, James. Let's go with:

First one:
"No one has helped translate this article yet."

Second one:
"A revision must be based on the English article."

Comment 11

[Scoobidiver (away)]

bump!

Comment 12

[Tanay Gavankar [:tgavankar]]

Done in https://github.com/mozilla/kitsune/commit/75287ed

Comment 13

[Ricky Rosario [:rrosario, :r1cky]]

Landed this on prod now.